Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26069

Create requirements list for new Filter implementation

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F20-3 (August), AP F20-4 (September)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      After discussion with Krzysztof Findeisen about approaching implementation of the new Filter design, we wanted to write down a list of requirements for the new system. RFC-541 was more focused on technical requirements, but some of the comments there can be built on to help with use case requirements. RFC-624 provides a design, but discussion since that has led to some questions about how exactly that design maps to how this system would be used.

      For this ticket, I will write up (probably not a DMTN?) a list of use cases and requirements for Filters in the stack, based on the above RFCs, my own experiences with the Instrument FilterDefinitions, and expectations for how filter names are used for photometry.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26259 Create design sketch for new filter system

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26614 Create RFC for new filter design

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26181 Ensure that filters are defined in pipetask multiprocessing

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-541 Design better (and Gen3-friendly) way of representing bandpass filters in code

          • Withdrawn

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-624 Replace afw.image.Filter with global-free label-only classes

          • Retired

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            The requirements list and other notes are on this confluence page:

            https://confluence.lsstcorp.org/pages/viewpage.action?pageId=140283016

            Jim Bosch: do you believe that this encompasses all the necessary requirements for the new FilterLabel system? I'm not sure whether the middleware section is complete enough, but I also don't know what needs to go in there.

            The code sketches I wrote will be modified more and reviewed separately as DM-26259.

            Show
            Parejkoj John Parejko added a comment - The requirements list and other notes are on this confluence page: https://confluence.lsstcorp.org/pages/viewpage.action?pageId=140283016 Jim Bosch : do you believe that this encompasses all the necessary requirements for the new FilterLabel system? I'm not sure whether the middleware section is complete enough, but I also don't know what needs to go in there. The code sketches I wrote will be modified more and reviewed separately as DM-26259 .
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I think this includes everything we need now, and I'm pretty confident any new middleware needs would basically be additions (to FilterDefinitions in obs_base) that would not affect code that gets filters but does not define them.

            By far the biggest middleware priority for filter work is just removing the current constraint that one (and only one) CameraMapper must be instantiated in a process in order for Filter to be usable.

            Show
            jbosch Jim Bosch added a comment - I think this includes everything we need now, and I'm pretty confident any new middleware needs would basically be additions (to FilterDefinitions in obs_base) that would not affect code that gets filters but does not define them. By far the biggest middleware priority for filter work is just removing the current constraint that one (and only one) CameraMapper must be instantiated in a process in order for Filter to be usable.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Returning this to "In progress" after discussion regarding middleware requirements re: unique labels. We need to say something about that in the above requirements list one way or the other.

            Show
            Parejkoj John Parejko added a comment - - edited Returning this to "In progress" after discussion regarding middleware requirements re: unique labels. We need to say something about that in the above requirements list one way or the other.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Re-closing this after another requirements discussion on #dm-middleware (with updates to the Confluence page). While we may still need to iterate on requirements as development proceeds, I don't think we want to keep this issue open until the new filter system is shipped.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Re-closing this after another requirements discussion on #dm-middleware (with updates to the Confluence page). While we may still need to iterate on requirements as development proceeds, I don't think we want to keep this issue open until the new filter system is shipped.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Jim Bosch
              Watchers:
              Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.