Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26069

Create requirements list for new Filter implementation

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • 2
    • AP F20-3 (August), AP F20-4 (September)
    • Alert Production
    • No

    Description

      After discussion with krzys about approaching implementation of the new Filter design, we wanted to write down a list of requirements for the new system. RFC-541 was more focused on technical requirements, but some of the comments there can be built on to help with use case requirements. RFC-624 provides a design, but discussion since that has led to some questions about how exactly that design maps to how this system would be used.

      For this ticket, I will write up (probably not a DMTN?) a list of use cases and requirements for Filters in the stack, based on the above RFCs, my own experiences with the Instrument FilterDefinitions, and expectations for how filter names are used for photometry.

      Attachments

        Issue Links

          Activity

            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue relates to RFC-624 [ RFC-624 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to RFC-541 [ RFC-541 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-26181 [ DM-26181 ]
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Epic Link DM-25145 [ 435263 ]
            swinbank John Swinbank made changes -
            Link This issue blocks DM-26259 [ DM-26259 ]
            swinbank John Swinbank made changes -
            Sprint AP F20-3 (August) [ 1033 ]
            swinbank John Swinbank made changes -
            Link This issue blocks DM-26614 [ DM-26614 ]
            Parejkoj John Parejko added a comment -

            The requirements list and other notes are on this confluence page:

            https://confluence.lsstcorp.org/pages/viewpage.action?pageId=140283016

            jbosch: do you believe that this encompasses all the necessary requirements for the new FilterLabel system? I'm not sure whether the middleware section is complete enough, but I also don't know what needs to go in there.

            The code sketches I wrote will be modified more and reviewed separately as DM-26259.

            Parejkoj John Parejko added a comment - The requirements list and other notes are on this confluence page: https://confluence.lsstcorp.org/pages/viewpage.action?pageId=140283016 jbosch : do you believe that this encompasses all the necessary requirements for the new FilterLabel system? I'm not sure whether the middleware section is complete enough, but I also don't know what needs to go in there. The code sketches I wrote will be modified more and reviewed separately as DM-26259 .
            Parejkoj John Parejko made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            sullivan Ian Sullivan made changes -
            Sprint AP F20-3 (August) [ 1033 ] AP F20-3 (August), AP F20-4 (September) [ 1033, 1039 ]
            jbosch Jim Bosch added a comment -

            I think this includes everything we need now, and I'm pretty confident any new middleware needs would basically be additions (to FilterDefinitions in obs_base) that would not affect code that gets filters but does not define them.

            By far the biggest middleware priority for filter work is just removing the current constraint that one (and only one) CameraMapper must be instantiated in a process in order for Filter to be usable.

            jbosch Jim Bosch added a comment - I think this includes everything we need now, and I'm pretty confident any new middleware needs would basically be additions (to FilterDefinitions in obs_base) that would not affect code that gets filters but does not define them. By far the biggest middleware priority for filter work is just removing the current constraint that one (and only one) CameraMapper must be instantiated in a process in order for Filter to be usable.
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Done [ 10002 ] To Do [ 10001 ]
            Parejkoj John Parejko made changes -
            Watchers Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen [ Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen ] Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Tim Jenness [ Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Tim Jenness ]
            Parejkoj John Parejko added a comment - - edited

            Returning this to "In progress" after discussion regarding middleware requirements re: unique labels. We need to say something about that in the above requirements list one way or the other.

            Parejkoj John Parejko added a comment - - edited Returning this to "In progress" after discussion regarding middleware requirements re: unique labels. We need to say something about that in the above requirements list one way or the other.
            Parejkoj John Parejko made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            krzys Krzysztof Findeisen made changes -
            Labels filter-remake
            krzys Krzysztof Findeisen made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]
            krzys Krzysztof Findeisen added a comment - - edited

            Re-closing this after another requirements discussion on #dm-middleware (with updates to the Confluence page). While we may still need to iterate on requirements as development proceeds, I don't think we want to keep this issue open until the new filter system is shipped.

            krzys Krzysztof Findeisen added a comment - - edited Re-closing this after another requirements discussion on #dm-middleware (with updates to the Confluence page). While we may still need to iterate on requirements as development proceeds, I don't think we want to keep this issue open until the new filter system is shipped.

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Jim Bosch
              Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.