[DM-26070] Add visit definition to ap_verify - Jira

XML

Word

Printable

Details

Type: Improvement
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: ap_verify
Labels:
- gen3-middleware

Story Points:
3
Epic Link:
f20a-ap-infrastructure
Sprint:
AP F20-2 (July), AP F20-3 (August)
Team:
Alert Production

Description

~~DM-21915~~ implemented ingestion of ap_verify datasets in Gen3DatasetIngestTask, but neglected to include visit definition. This means that the repository, following ingestion, is not in a state where the AP pipeline can be run on it.

Add visit definition to Gen3DatasetIngestTask, so that users running ingest_dataset.py from the command line get a repository that is usable immediately. Because ap_verify datasets are necessarily complete and self-contained, the usual complications to doing visit definition (e.g., partially ingested visits) do not apply.

Attachments

Issue Links

blocks

DM-21919 Run ap_verify end-to-end in Gen 3

Done

relates to

DM-21915 Support Gen 3 ingestion of ap_verify datasets

Done

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Krzysztof Findeisen added a comment - 24/Jul/20 10:58 PM

This is another ticket where work ended up getting scattered across multiple packages:

ap_verify#96 – the main work of the ticket, 74 lines of code
obs_base#277 – a one-line bug fix to _GroupExposuresByGroupMetadataTask
obs_subaru#303, obs_lsst#234 – a 7-line config file for Gen3DatasetIngestTask, should be identical.
ap_verify_dataset_template#15, ap_verify_testdata#12 – 31 lines of change to the dataset converter script, should be identical. ap_verify_testdata also has changes to the Gen 3 repository; I don't think there's anything human-reviewable there.
ap_verify_ci_hits2015#14, ap_verify_ci_cosmos_pdr2#5 – these are repository updates based on ap_verify_dataset_template; I don't think there's anything reviewable in these two packages.

Show

Krzysztof Findeisen added a comment - 24/Jul/20 10:58 PM This is another ticket where work ended up getting scattered across multiple packages: ap_verify#96 – the main work of the ticket, 74 lines of code obs_base#277 – a one-line bug fix to _GroupExposuresByGroupMetadataTask obs_subaru#303 , obs_lsst#234 – a 7-line config file for Gen3DatasetIngestTask , should be identical. ap_verify_dataset_template#15 , ap_verify_testdata#12 – 31 lines of change to the dataset converter script, should be identical. ap_verify_testdata also has changes to the Gen 3 repository; I don't think there's anything human-reviewable there. ap_verify_ci_hits2015#14 , ap_verify_ci_cosmos_pdr2#5 – these are repository updates based on ap_verify_dataset_template ; I don't think there's anything reviewable in these two packages.

Hide

Permalink

Gabor Kovacs [X] (Inactive) added a comment - 06/Aug/20 10:11 PM

So far I understand the gen3 details, the changes look good.

Show

Gabor Kovacs [X] (Inactive) added a comment - 06/Aug/20 10:11 PM So far I understand the gen3 details, the changes look good.

People

Assignee:: Krzysztof Findeisen

Reporter:: Krzysztof Findeisen

Reviewers:: Gabor Kovacs [X] (Inactive)

Watchers:: Gabor Kovacs [X] (Inactive), Krzysztof Findeisen

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 22/Jul/20 10:42 PM

Updated:: 06/Aug/20 11:52 PM

Resolved:: 06/Aug/20 11:52 PM

Jenkins

No builds found.

Data Management