Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26070

Add visit definition to ap_verify

    Details

      Description

      DM-21915 implemented ingestion of ap_verify datasets in Gen3DatasetIngestTask, but neglected to include visit definition. This means that the repository, following ingestion, is not in a state where the AP pipeline can be run on it.

      Add visit definition to Gen3DatasetIngestTask, so that users running ingest_dataset.py from the command line get a repository that is usable immediately. Because ap_verify datasets are necessarily complete and self-contained, the usual complications to doing visit definition (e.g., partially ingested visits) do not apply.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            This is another ticket where work ended up getting scattered across multiple packages:

            Show
            krzys Krzysztof Findeisen added a comment - This is another ticket where work ended up getting scattered across multiple packages: ap_verify#96 – the main work of the ticket, 74 lines of code obs_base#277 – a one-line bug fix to _GroupExposuresByGroupMetadataTask obs_subaru#303 , obs_lsst#234 – a 7-line config file for Gen3DatasetIngestTask , should be identical. ap_verify_dataset_template#15 , ap_verify_testdata#12 – 31 lines of change to the dataset converter script, should be identical. ap_verify_testdata also has changes to the Gen 3 repository; I don't think there's anything human-reviewable there. ap_verify_ci_hits2015#14 , ap_verify_ci_cosmos_pdr2#5 – these are repository updates based on ap_verify_dataset_template ; I don't think there's anything reviewable in these two packages.
            Hide
            gkovacs Gabor Kovacs added a comment -

            So far I understand the gen3 details, the changes look good.

            Show
            gkovacs Gabor Kovacs added a comment - So far I understand the gen3 details, the changes look good.

              People

              • Assignee:
                krzys Krzysztof Findeisen
                Reporter:
                krzys Krzysztof Findeisen
                Reviewers:
                Gabor Kovacs
                Watchers:
                Gabor Kovacs, Krzysztof Findeisen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: