Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26081

Make Hexapod and Rotator configurable CSCs

    XMLWordPrintable

    Details

      Description

      At present the Hexapod and Rotator are not configurable. Update the base class to make them configurable. Rotator will offer TCP/IP configuration. Hexapod will also offer compensation configuration once DM-25856 is implemented.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            lsst.ts.hexrotcomm.BaseCsc presently inherits from lsst.ts.salobj.Controller, because the summary state is kept in the low-level controller. However, to continue doing that would require copying a lot of code from lsst.ts.salobj.ConfigurableCsc. Instead change lsst.ts.hexrotcomm.BaseCsc to inherit from lsst.ts.salobj.ConfigurableCsc. I did that in two steps:

            • First change lsst.ts.hexrotcomm.BaseCsc to inherit from lsst.ts.salobj.BaseCsc. That requires overriding some of the standard behavior due to the summary state being in the low-level controller.
            • Change lsst.ts.hexrotcomm.BaseCsc to inherit from lsst.ts.salobj.ConfigurableCsc. That is a simple change.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited lsst.ts.hexrotcomm.BaseCsc presently inherits from lsst.ts.salobj.Controller, because the summary state is kept in the low-level controller. However, to continue doing that would require copying a lot of code from lsst.ts.salobj.ConfigurableCsc. Instead change lsst.ts.hexrotcomm.BaseCsc to inherit from lsst.ts.salobj.ConfigurableCsc. I did that in two steps: First change lsst.ts.hexrotcomm.BaseCsc to inherit from lsst.ts.salobj.BaseCsc. That requires overriding some of the standard behavior due to the summary state being in the low-level controller. Change lsst.ts.hexrotcomm.BaseCsc to inherit from lsst.ts.salobj.ConfigurableCsc. That is a simple change. Pull requests: https://github.com/lsst-ts/ts_hexrotcomm/pull/18 https://github.com/lsst-ts/ts_config_ocs/pull/15 https://github.com/lsst-ts/ts_hexapod/pull/21 https://github.com/lsst-ts/ts_rotator/pull/16
            Hide
            pkubanek Petr Kubanek added a comment -

            Well performed complex change needed due to Hexapod requiring configuration.

            Show
            pkubanek Petr Kubanek added a comment - Well performed complex change needed due to Hexapod requiring configuration.
            Hide
            rowen Russell Owen added a comment - - edited

            Released:

            • ts_config_ocs v0.6.0
            • ts_hexrotcomm v0.7.0
            • ts_hexapod v0.7.0
            • ts_rotator v0.5.0

            and updated the served docs for all but the first (which has no docs).

            Show
            rowen Russell Owen added a comment - - edited Released: ts_config_ocs v0.6.0 ts_hexrotcomm v0.7.0 ts_hexapod v0.7.0 ts_rotator v0.5.0 and updated the served docs for all but the first (which has no docs).

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Petr Kubanek
              Watchers:
              Petr Kubanek, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.