Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:3
-
Epic Link:
-
Sprint:TSSW Sprint - Aug 3 - Aug 17, TSSW Sprint - Aug 17 - Aug 31, TSSW Sprint - Aug 31 - Sep 14, TSSW Sprint - Sep 28 - Oct 12, TSSW Sprint - Oct 12 - Oct 26
-
Team:Telescope and Site
-
Urgent?:No
Description
Update the M2 SAL interface based on the latest xml file. After the summit test at Feb. in this year, the M2 xml has been updated to support more use cases than before. This task is to update the software to support this. This task is in the phase 1.
Attachments
Issue Links
Activity
Fixed all SAL functions.
Fixed some unit transition and refactored the methods to run/kill the SAL monitor and remove the shared memory.
I refactored the code. When I ran it, I got the following message to stuck the application:
Client 0 processor waiting for reader command_abort |
Client 0 processor waiting for reader command_abort |
Client 0 processor waiting for reader command_abort |
After the testing, I realized that there is no TestID control on the connect vi for MTM2 and MTMount. I generated the related bug ticket: DM-27265 for Dave to help!
After the discussion with Dave, there is no TestID for the singletons.
The SAL monitor related vis are tested without the problem. After setting the CSC index to be 0, I can trigger the reader as the following:
LabVIEW SAL Monitor for MTM2 is ready |
Client 0 Connected |
Client 0 salProcessor command_abort |
createReader : 0x15d3ac8 , MTM2::command_abort_77d0ed4d , MTM2_command_abort_77d0ed4d |
createWriter2 : 0x15d14d8 , MTM2::ackcmd_e1052973 , MTM2_ackcmd_e1052973 |
Client 0 salProcessor command_applyForces |
createReader : 0x2c344e8 , MTM2::command_applyForces_993b0fc2 , MTM2_command_applyForces_993b0fc2 |
Client 0 salProcessor command_clearErrors |
createReader : 0x14b92d8 , MTM2::command_clearErrors_b37ebe28 , MTM2_command_clearErrors_b37ebe28 |
Client 0 salProcessor command_disable |
createReader : 0x15ceb08 , MTM2::command_disable_d3f43964 , MTM2_command_disable_d3f43964 |
Client 0 salProcessor command_enable |
createReader : 0x15c4c88 , MTM2::command_enable_c8a35061 , MTM2_command_enable_c8a35061 |
Client 0 salProcessor command_enterControl |
createReader : 0x15a2138 , MTM2::command_enterControl_02110dec , MTM2_command_enterControl_02110dec |
Client 0 salProcessor command_exitControl |
createReader : 0x15a8d78 , MTM2::command_exitControl_48cb2a16 , MTM2_command_exitControl_48cb2a16 |
Client 0 salProcessor command_positionMirror |
createReader : 0x1593428 , MTM2::command_positionMirror_5317657e , MTM2_command_positionMirror_5317657e |
Client 0 salProcessor command_resetForceOffsets |
createReader : 0x159bb48 , MTM2::command_resetForceOffsets_18e01ea6 , MTM2_command_resetForceOffsets_18e01ea6 |
Client 0 salProcessor command_selectInclinationSource |
createReader : 0x1570128 , MTM2::command_selectInclinationSource_14e69712 , MTM2_command_selectInclinationSource_14e69712 |
Client 0 salProcessor command_setTemperatureOffset |
createReader : 0x1577388 , MTM2::command_setTemperatureOffset_34f34975 , MTM2_command_setTemperatureOffset_34f34975 |
Client 0 salCommand command_standby |
createReader2 : 0x157f698 , MTM2::ackcmd_e1052973 , MTM2_ackcmd_e1052973 |
createWriter : 0x157f1b8 , MTM2::command_standby_8611357c , MTM2_command_standby_8611357c |
Client 0 salProcessor command_start |
createReader : 0x15882f8 , MTM2::command_start_26e933d7 , MTM2_command_start_26e933d7 |
Client 0 salProcessor command_switchForceBalanceSystem |
createReader : 0x1503578 , MTM2::command_switchForceBalanceSystem_907750ad , MTM2_command_switchForceBalanceSystem_907750ad |
Client 0 salProcessor command_standby |
createReader : 0x1508798 , MTM2::command_standby_8611357c , MTM2_command_standby_8611357c |
I can let the LabVIEW to get the SAL data already:
The information from Monitor is here:
Incoming MTM2_command_start settingsToApply = 1 |
Client 0 got a command cmdId=1603947651 command_start |
Client 0 ackCommand command_start |
=== [ackCommand_start] acknowledging a command with :
|
seqNum : 1603947651 |
ack : 300 |
error : 0 |
host : -1062709719 |
origin : 4274 |
identity : MTM2
|
result :
|
Based on How do I Open a Vi reference to and run a Polymorphic VI?, I can not get the strictly typed vi reference from the polymorphic vi.
I need to update the configuration in the CTIO Jenkins instance to download the git submodules to run all the test. The details is Checkout submodules in Jenkins with Github organisation plugin. In addition, it looks like I do not need to modify the Jenkinsfile.
Please help to review the PR:
https://github.com/lsst-ts/ts_mtm2/pull/21
The main update is to support the SAL v5.0.0. I also put the repo to the CTIO jenkins to do the CI/CD test.
Thanks!
Great work to enhance our CI testing when LV is involved
Dave Mills
added a comment - Great work to enhance our CI testing when LV is involved
Added the SAL LabVIEW libraries of MTM2 and MTMount. Began to update the SAL interface by using the polymorphic vi.