Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26205

Fix obs_lsst to handle corner raft data

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Team:
      DM Science
    • Urgent?:
      No

      Description

      The camGeom changes to handle guider and wavefront chips were done blind, without any real camera data from the corner rafts.  A number of problems showed up when we started getting BOT data:

      1. SG0 and SG1 were swapped
      2. C00 is flipped top-to-bottom
      3. The WF chips think that they have 16, not 8, channels
      4. The rotations are incorrect

      Please fix these.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          rhl Robert Lupton created issue -
          rhl Robert Lupton made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          I think I've fixed up the geometry, certainly it does the right thing with the data in /scratch/jchiang/BOT_data/pinhole/repo_patched on lsst-dev.  Note: this data was patched due to bugs in the camera, and this branch should not be merged until tested on a new dataset that should be taken this week.

          I had to make significant changes to make this work, so could you check that I haven't broken things that you did?

          Show
          rhl Robert Lupton added a comment - I think I've fixed up the geometry, certainly it does the right thing with the data in /scratch/jchiang/BOT_data/pinhole/repo_patched on lsst-dev.  Note: this data was patched due to bugs in the camera, and this branch should not be merged until tested on a new dataset that should be taken this week. I had to make significant changes to make this work, so could you check that I haven't broken things that you did?
          rhl Robert Lupton made changes -
          Reviewers Simon Krughoff [ krughoff ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          rhl Robert Lupton made changes -
          Status In Review [ 10004 ] In Progress [ 3 ]
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          Taking this back as it turns out that there were problems at SLAC that lead to an apparent switch of SG0 and SG1.  I'm hoping to be able to revert to the original geometry (the amp problems were still there, I think, so this ticket is probably not moot)

          Show
          rhl Robert Lupton added a comment - Taking this back as it turns out that there were problems at SLAC that lead to an apparent switch of SG0 and SG1.  I'm hoping to be able to revert to the original geometry (the amp problems were still there, I think, so this ticket is probably not moot)
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          There was also LCA-13381 so that the WF chips are now known to be the top, not the bottom half of regular ITL devices.  Some of the changes in this ticket were due to this, in particular the rotations of the SW0/1 devices.

          Show
          rhl Robert Lupton added a comment - There was also LCA-13381 so that the WF chips are now known to be the top , not the bottom half of regular ITL devices.  Some of the changes in this ticket were due to this, in particular the rotations of the SW0/1 devices.
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          I've reverted the SG0/1 changes and created a new PR.  I have confirmed visually using pinhole images that the geometry is correct.

           

          Show
          rhl Robert Lupton added a comment - I've reverted the SG0/1 changes and created a new PR.  I have confirmed visually using pinhole images that the geometry is correct.  
          rhl Robert Lupton made changes -
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          Permalink
          krughoff Simon Krughoff added a comment -

          One small comment in the PR

          Show
          krughoff Simon Krughoff added a comment - One small comment in the PR
          krughoff Simon Krughoff made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          swinbank John Swinbank made changes -
          Team DM Science [ 12218 ]
          Hide
          Permalink
          lguy Leanne Guy added a comment -

          Robert Lupton This ticket appears to be complete and merged. If so, can you close it please. 

          Show
          lguy Leanne Guy added a comment - Robert Lupton  This ticket appears to be complete and merged. If so, can you close it please. 
          rhl Robert Lupton made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          Permalink
          rhl Robert Lupton added a comment -

          Tested on real BOT data of pinhole data.

          Show
          rhl Robert Lupton added a comment - Tested on real BOT data of pinhole data.

            People

            Assignee:
            rhl Robert Lupton
            Reporter:
            rhl Robert Lupton
            Reviewers:
            Simon Krughoff
            Watchers:
            James Chiang, Leanne Guy, Robert Lupton, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.