Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26231

Remove defaultFilter in LoadReferenceObjectsConfig

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP F20-6 (November), AP S22-1 (December)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Following release 22, remove the deprecated defaultFilter config option from LoadReferenceObjectsConfig. This will entail some refactoring of unittests, but I don't believe it shows up in any other places.

      This ticket completes the work of RFC-716.

        Attachments

          Issue Links

            Activity

            Hide
            sullivan Ian Sullivan added a comment -

            This will now follow release 22.

            Show
            sullivan Ian Sullivan added a comment - This will now follow release 22.
            Hide
            Parejkoj John Parejko added a comment - - edited
            Show
            Parejkoj John Parejko added a comment - - edited Jenkins (with ci_hsc ci_imsim ci_cpp_gen3): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35602/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Kenneth Herner: do you mind doing this ~100 line review? It's mostly removal, but includes changing some kwargs to required args (they don't make sense as optional now). The one big changed block is mostly a re-indent after the removal of an outer loop in a test.

            PR: https://github.com/lsst/meas_algorithms/pull/272

            Show
            Parejkoj John Parejko added a comment - Kenneth Herner : do you mind doing this ~100 line review? It's mostly removal, but includes changing some kwargs to required args (they don't make sense as optional now). The one big changed block is mostly a re-indent after the removal of an outer loop in a test. PR: https://github.com/lsst/meas_algorithms/pull/272
            Hide
            kherner Kenneth Herner added a comment -

            Review is done.

            Show
            kherner Kenneth Herner added a comment - Review is done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Kenneth Herner
              Watchers:
              Ian Sullivan, John Parejko, Kenneth Herner, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.