Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26244

A few hot-fixes for pipe_analysis scripts post DM-22255

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_analysis
    • Labels:
      None
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      DRP F20-3 (Aug)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Due to the sweeping changes to the pipe_analysis scripts of DM-22255, there have been some inevitable bugs introduced that are being caught via more detailed scrutiny of the plots as well as some non-standard (i.e. non-default) run modes. This ticket collects and fixes three such bugs:

      • fixing the plotting and logic of ccd outlines to use the correct WCS
      • moving setting of newly added plotInfoDict so that it is available when using non-default configs (e.g. plotMatchesOnly=True, etc.)
      • add missing plotList.append for the sky object plots in visitAnalysis.py so that the plots get persisted (I noticed they were missing in recent RC2 processing runs)

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22255 Move plotting IO out of plotting functions in coaddAnalysis

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26456 Create sky object performance metric trackers

          • Done

            Activity

            Ascending order - Click to sort in descending order
            10 older comments
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Garrhhh...so sorry about that!  Fixes were required on obs_test and obs_lsst. I've pushed tickets/DM-26244 branch to them and started Jenkins. Kian-Tat Lim, once I've got Jenkins passing, would you prefer I keep the fixes on this ticket (i.e. create PRs for the two new branches for review), or does this require opening a new ticket to properly document the breakage/fix?

            Show
            lauren Lauren MacArthur added a comment - Garrhhh...so sorry about that!  Fixes were required on  obs_test and obs_lsst . I've pushed tickets/ DM-26244 branch to them and started Jenkins . Kian-Tat Lim , once I've got Jenkins passing, would you prefer I keep the fixes on this ticket (i.e. create PRs for the two new branches for review), or does this require opening a new ticket to properly document the breakage/fix?
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            I've made the PRs. Kian-Tat Lim had approved the obs_test one. Sophie Reed, would you mind having a look at the obs_lsst one (https://github.com/lsst/obs_lsst/pull/246) as it updates the policy files there for to include the subdir.

            Show
            lauren Lauren MacArthur added a comment - I've made the PRs. Kian-Tat Lim had approved the obs_test one. Sophie Reed , would you mind having a look at the obs_lsst one ( https://github.com/lsst/obs_lsst/pull/246 ) as it updates the policy files there for to include the subdir .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            As a general comment I think tickets/DM-26244-hotfix is a perfectly reasonable branch name to quickly recover breakage of master without needing a new ticket.

            Show
            tjenness Tim Jenness added a comment - As a general comment I think tickets/ DM-26244 -hotfix is a perfectly reasonable branch name to quickly recover breakage of master without needing a new ticket.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Thanks Tim. These branches are going into different repos, so I think it’s ok to leave off the “-hotfix” postfix here.

            Jenkins passed, so I’m just waiting on a final sign-off from Sophie on the obs_lsst PR before merging.

            Show
            lauren Lauren MacArthur added a comment - Thanks Tim. These branches are going into different repos, so I think it’s ok to leave off the “-hotfix” postfix here. Jenkins passed, so I’m just waiting on a final sign-off from Sophie on the obs_lsst PR before merging.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Thanks all!  I've merged the fixes to master and have set off a master Jenkins run just to be sure.  Again, please accept my most sincere apologies for this slip-up and any trouble it may have caused...

            Show
            lauren Lauren MacArthur added a comment - Thanks all!  I've merged the fixes to master and have set off a master Jenkins run just to be sure.  Again, please accept my most sincere apologies for this slip-up and any trouble it may have caused...

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Sophie Reed
              Watchers:
              Kian-Tat Lim, Lauren MacArthur, Lee Kelvin, Sophie Reed, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.