Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_diffim, pipe_tasks
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:AP S21-3 (February)
-
Team:Alert Production
-
Urgent?:No
Description
As reported by Jeffrey Carlin on Slack, some of the diaSrc catalog instrumental flux units are wrong. Many instFluxErr entries erroneously have units of pixels, and all forced instFluxes and their errors have no units. All these units should be counts.
I think this is all the relevant code:
https://github.com/lsst/ip_diffim/blob/master/python/lsst/ip/diffim/dipoleFitTask.py#L998
https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/imageDifference.py#L376-L381
Attachments
Activity
Sure.
Kenneth Herner
added a comment - Sure. I've reviewed the changes in the DM-26372 branches of ip_diffim and pipe_tasks; they look fine. As long as Jenkins gives the thumbs up I think you are good to go.
Kenneth Herner
added a comment - I've reviewed the changes in the DM-26372 branches of ip_diffim and pipe_tasks; they look fine. As long as Jenkins gives the thumbs up I think you are good to go. CI checks were successful and the new code looks correct.
Kenneth Herner
added a comment - CI checks were successful and the new code looks correct.
Would you be willing to review a few lines of changes in pipe_tasks and ip_diffim, Ken? Jenkins is running at https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33558/pipeline/.
This was something Jeff pointed out a while ago that I forgot about.