Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26476

Add "reason for observation" to Gen3 registry

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      0.5
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Update the gen3 registry to use the observation reason added in DM-26550.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            After discussion with Robert Lupton on Slack the decision is:

            • Add an "observation_reason" field to ObservationInfo (this is a string).
            • By default, in absence of other information, set it to "science" when observation_type = science and "calibration" for every other case.
            • For LSST test stands populate it from the TESTTYPE header. For test stands there is a finite set of allowed values so we have to decide what happens when something is encountered that is not in the set. Either we report it anyhow or we use "unknown".
            • Finally, update Gen3 registry to add "observation_reason" as a string.
            • To be consistent with observation_type I'll likely lower case them.
            Show
            tjenness Tim Jenness added a comment - After discussion with Robert Lupton on Slack the decision is: Add an "observation_reason" field to ObservationInfo (this is a string). By default, in absence of other information, set it to "science" when observation_type = science and "calibration" for every other case. For LSST test stands populate it from the TESTTYPE header. For test stands there is a finite set of allowed values so we have to decide what happens when something is encountered that is not in the set. Either we report it anyhow or we use "unknown". Finally, update Gen3 registry to add "observation_reason" as a string. To be consistent with observation_type I'll likely lower case them.
            Hide
            tjenness Tim Jenness added a comment -

            Simon Krughoff are you able to review this change? It's about 5 lines in 2 packages. Not a huge rush.

            Show
            tjenness Tim Jenness added a comment - Simon Krughoff are you able to review this change? It's about 5 lines in 2 packages. Not a huge rush.
            Hide
            krughoff Simon Krughoff added a comment -

            Tim Jenness the changes to these two packages seem fine to me, but with the discussion of using TESTTYPE to populate observation_reason made me expect changes to obs_lsst as well as the changes to obs_base and daf_butler. Is that happening elsewhere, or did I miss something?

            Show
            krughoff Simon Krughoff added a comment - Tim Jenness the changes to these two packages seem fine to me, but with the discussion of using TESTTYPE to populate observation_reason made me expect changes to obs_lsst as well as the changes to obs_base and daf_butler. Is that happening elsewhere, or did I miss something?
            Hide
            tjenness Tim Jenness added a comment -

            That all happened in DM-26550 – this ticket split into two parts – the changes to the translator in one ticket and the changes to registry in the other. I needed to defer the registry changes until we could group it with other registry changes. I never updated the description of the ticket.

            Show
            tjenness Tim Jenness added a comment - That all happened in DM-26550 – this ticket split into two parts – the changes to the translator in one ticket and the changes to registry in the other. I needed to defer the registry changes until we could group it with other registry changes. I never updated the description of the ticket.
            Hide
            krughoff Simon Krughoff added a comment -

            Fair enough. In that case, LGTM

            Show
            krughoff Simon Krughoff added a comment - Fair enough. In that case, LGTM

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Simon Krughoff
              Watchers:
              Gregory Dubois-Felsmann, Kian-Tat Lim, Merlin Fisher-Levine, Robert Lupton, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.