Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26493

Support the Shared Enum in LabVIEW

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:
    • Story Points:
      3
    • Sprint:
      TSSW Sprint - Aug 17 - Aug 31, TSSW Sprint - Aug 31 - Sep 14
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Support the shared enum in LabVIEW. Based on Dave, the bug described in DM-26270 can not be fixed in his side. Therefore, the ts_SALLabVIEW may need to be updated to support this.

      To do this, maybe I will need to pass "const" and "enum : xxxx" in the IDL file.

      This ticket will try to fix the space/tab and private in the IDL file.

        Attachments

          Issue Links

            Activity

            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            Generated the test data of Test CSC by ts_sal v5.0.0 (or v5.0.0 RC1). There were some update in IDL file to break this repository. Need to figure out the problems.

            Discussed with Dave. He mentioned the ts_SALLabVIEW is sensitive to the space and tab. Need to check this.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Generated the test data of Test  CSC by ts_sal  v5.0.0 (or v5.0.0 RC1). There were some update in IDL file to break this repository. Need to figure out the problems. Discussed with Dave. He mentioned the ts_SALLabVIEW  is sensitive to the space and tab. Need to check this.
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            The following is the new IDL format:

            struct command_disable {
             long TestID;
             string<8> private_revCode; //private
             double private_sndStamp; //private
             double private_rcvStamp; //private
             long private_seqNum; //private
             string private_identity; //private
             long private_origin; //private
             long private_host; //private
             boolean value;
             };
             #pragma keylist command_disable TestID

            The private is the private attribute that maybe I do not need. Not sure the meaning of TestID and value here.

            In addition, this IDL does not look like the control:

            After the discussion with Dave, generated the DM-26525 and assign to him.

            Show
            ttsai Te-Wei Tsai added a comment - - edited The following is the new IDL format: struct command_disable { long TestID; string<8> private_revCode; //private double private_sndStamp; //private double private_rcvStamp; //private long private_seqNum; //private string private_identity; //private long private_origin; //private long private_host; //private boolean value; }; #pragma keylist command_disable TestID The private is the private attribute that maybe I do not need. Not sure the meaning of TestID and value here. In addition, this IDL does not look like the control: After the discussion with Dave, generated the DM-26525 and assign to him.
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            Fixed the problem of space and tab. Added the related unit tests. I replaced all tab to space in the IDL file of test data and made sure the file can be passed to all unit tests and began the update of controls in VI.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Fixed the problem of space and tab. Added the related unit tests. I replaced all tab to space in the IDL file of test data and made sure the file can be passed to all unit tests and began the update of controls in VI.
            Hide
            ttsai Te-Wei Tsai added a comment -

            Supported the shared enumeration such as the summary state based on the configuration file:

            Show
            ttsai Te-Wei Tsai added a comment - Supported the shared enumeration such as the summary state based on the configuration file:
            Hide
            ttsai Te-Wei Tsai added a comment -

            Please help to review the following PR:
            https://github.com/lsst-ts/ts_SALLabVIEW/pull/5

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the following PR: https://github.com/lsst-ts/ts_SALLabVIEW/pull/5 Thanks!
            Hide
            dmills Dave Mills added a comment -

            Tested and working

            Show
            dmills Dave Mills added a comment - Tested and working

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Dave Mills
              Watchers:
              Dave Mills, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.