Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26553

Create gen3 unittests and test CreateApFakes pipeline tasks on data.

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_pipe
    • Labels:
      None
    • Story Points:
      6
    • Epic Link:
    • Sprint:
      AP F20-4 (September)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      DM-25748 finished the bulk of the testing and code to create randoms for fakes in AP. Next step is to finish tests for the runQuantum method and test an initial run of the ap_pipe pipeline with fakes inserted.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            As far as I'm concerned it's up to Sophie Reed how important the fakeSourceCat issue is. I signed off on my part of the review, and I don't think I have any pressing comments other than the prerequisiteInputs bug.

            Show
            krzys Krzysztof Findeisen added a comment - As far as I'm concerned it's up to Sophie Reed how important the fakeSourceCat issue is. I signed off on my part of the review, and I don't think I have any pressing comments other than the prerequisiteInputs bug.
            Hide
            sophiereed Sophie Reed added a comment -

            I think it would be a shame to lose the ability to insert visit dependent fakes. I guess the other option is to refactor the code to use a tract level catalogue for both. Perhaps a multi index dataframe with an index for each visit in the tract.

            Show
            sophiereed Sophie Reed added a comment - I think it would be a shame to lose the ability to insert visit dependent fakes. I guess the other option is to refactor the code to use a tract level catalogue for both. Perhaps a multi index dataframe with an index for each visit in the tract.
            Hide
            cmorrison Chris Morrison added a comment - - edited

            Talked to Sophie Reed yesterday about future needs for fakes. Further discussion of visit level fakes in Gen3 beyond this ticket. Asking for reviewers to mark review complete.

            Show
            cmorrison Chris Morrison added a comment - - edited Talked to Sophie Reed yesterday about future needs for fakes. Further discussion of visit level fakes in Gen3 beyond this ticket. Asking for reviewers to mark review complete.
            Hide
            sophiereed Sophie Reed added a comment -

            I thought that we came to the conclusion that adding a config option to allow it to read in fits files from a directory directly, similar to the way insertFakes can currently take a fits file instead of using the standard file, would mean that it could maintain all of the current functionality in gen 3. Are you saying that this is work that is going onto another ticket? I think that would be appropriate but wanted to clarify so I, or others, don't forget in future.

            Show
            sophiereed Sophie Reed added a comment - I thought that we came to the conclusion that adding a config option to allow it to read in fits files from a directory directly, similar to the way insertFakes can currently take a fits file instead of using the standard file, would mean that it could maintain all of the current functionality in gen 3. Are you saying that this is work that is going onto another ticket? I think that would be appropriate but wanted to clarify so I, or others, don't forget in future.
            Hide
            cmorrison Chris Morrison added a comment -

            Implementing that functionality is for another ticket. Other than bug fixes to the Gen3 side of the code, this ticket has made no changes. We'll want to come up with a design we want going forward.

            Show
            cmorrison Chris Morrison added a comment - Implementing that functionality is for another ticket. Other than bug fixes to the Gen3 side of the code, this ticket has made no changes. We'll want to come up with a design we want going forward.

              People

              • Assignee:
                cmorrison Chris Morrison
                Reporter:
                cmorrison Chris Morrison
                Reviewers:
                Sophie Reed
                Watchers:
                Chris Morrison, Eric Bellm, John Swinbank, Krzysztof Findeisen, Sophie Reed
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: