Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26615

Remove afw.filter dependence from DCR model

    Details

    • Story Points:
      2
    • Sprint:
      AP F20-4 (September), AP F20-5 (October), AP F20-6 (November)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      In anticipation of the afw.Filter refactor (DM-26259) it has been noted that DCR is the only code making use of wavelength information stored in the filter definition. In order to simplify that transition and in light of needing to use the true filter transmission curves (DM-13668) eventually, I should temporarily move wavelength information to a new location and remove dependence on afw.Filter. That new location could be in the config of the Tasks, which in the future could be used as a user override even when the true transmission curves are available.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Noting that pipe_tasks/python/lsst/pipe/tasks/dcrAssembleCoadd.py does use getFilterProperty().getLambdaMin().

            Show
            tjenness Tim Jenness added a comment - Noting that pipe_tasks/python/lsst/pipe/tasks/dcrAssembleCoadd.py does use getFilterProperty().getLambdaMin() .
            Hide
            dtaranu Dan Taranu added a comment -

            Just a few minor comments on github. I do wonder if effectiveWavelength/bandwidth should be a NamedTuple/dataclass - does it ever make sense to specify only one and not the other? I suppose you can revisit that when implementing the other pending tickets.

            Show
            dtaranu Dan Taranu added a comment - Just a few minor comments on github. I do wonder if effectiveWavelength/bandwidth should be a NamedTuple/dataclass - does it ever make sense to specify only one and not the other? I suppose you can revisit that when implementing the other pending tickets.

              People

              • Assignee:
                sullivan Ian Sullivan
                Reporter:
                sullivan Ian Sullivan
                Reviewers:
                Dan Taranu
                Watchers:
                Dan Taranu, Ian Sullivan, John Parejko, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: