Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26616

Gain slope is inverted in EXPAPPROXIMATION case in plotPtc.py

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None

      Description

      When using the EXPAPPROXIMATION case, the slope of the green dotted line which represents the gain is inverted.  It should be 1/pars[1], not pars[1].  The attached plot labeled 'bad' shows the current code.  I edited line 832 to use 1/pars[1], and got the plot labeled 'good'.  note that this can't be the final fix, since pars[1] is defined differently between the EXPAPPROXIMATION and POLYNOMIAL cases.  The final fix will need a little more thought, like defining a variable 'slope' or using '1/gain' or something.

        Attachments

        1. invers_gain.png
          invers_gain.png
          1022 kB
        2. PTC_det10_bad.pdf
          61 kB
        3. PTC_det10_good.pdf
          61 kB

          Activity

          Hide
          plazas Andrés Alejandro Plazas Malagón added a comment -

           plotPhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/plazas/DM-26616 --id detector=10 -c datasetFileName=/project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543/calibrations/ptc/ptcDataset-det010.pkl --clobber-versions --clobber-config -j 1
          

          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - plotPhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/plazas/DM-26616 --id detector=10 -c datasetFileName=/project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543/calibrations/ptc/ptcDataset-det010.pkl --clobber-versions --clobber-config -j 1
          Hide
          mfisherlevine Merlin Fisher-Levine added a comment -

          Looks good to me.

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Looks good to me.
          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32588/pipeline

            People

            Assignee:
            plazas Andrés Alejandro Plazas Malagón
            Reporter:
            cslage Craig Lage
            Reviewers:
            Merlin Fisher-Levine
            Watchers:
            Andrés Alejandro Plazas Malagón, Craig Lage, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: