Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26641

Problem with log plots and problem with bad amps in ptc.py

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None

      Description

      I found two problems that need addressing in ptc.py:

      (1) In the EXPAPPROXIMATION plots, the log-log plots are actually linear.  See attached.

      (2) If all of the points in an amp get rejected in the _getInitialGoodPoints routine, then the program crashes.  We want it to continue and complete the other amps, even if one amp is bad.  There are two points where I've seen it crash.  One is the line "mask = mask & goodPoints", which is about line 1200, and the other is the line "mask = mask & newMask", which is about line 1230.  I think if either one of the inputs is all 'False', then it returns the following error: 

      TypeError: ufunc 'bitwise_and' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

      The following input string should generate the error:

      measurePhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --id detector=180 --visit-pairs 3020090200313,3020090200314 3020090200316,3020090200317 3020090200343,3020090200344 3020090200319,3020090200320 3020090200346,3020090200347 3020090200322,3020090200323 3020090200349,3020090200350 3020090200325,3020090200326 3020090200352,3020090200353 3020090200328,3020090200329 3020090200355,3020090200356 3020090200331,3020090200332 3020090200358,3020090200359 3020090200334,3020090200335 3020090200361,3020090200362 3020090200337,3020090200338 3020090200364,3020090200365 3020090200340,3020090200341 3020090200367,3020090200368 3020090200370,3020090200371 -c maxMeanSignal=100000 ptcFitType=EXPAPPROXIMATION --clobber-config --clobber-versions -j 1
      

        Attachments

        1. logPtc.png
          logPtc.png
          689 kB
        2. PTC_det10_2020SEP09.pdf
          81 kB
        3. PTC_det10_good.pdf
          61 kB

          Issue Links

            Activity

            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited

            w_2020_36

            plotPhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/plazas/DM-26641 --id detector=10 -c datasetFileName=/project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543/calibrations/ptc/ptcDataset-det010.pkl --clobber-versions --clobber-config -j 1
            

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - - edited w_2020_36 plotPhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/plazas/DM-26641 --id detector=10 -c datasetFileName=/project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543/calibrations/ptc/ptcDataset-det010.pkl --clobber-versions --clobber-config -j 1
            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment -

            If all the points in an amp are bad, continue.

            measurePhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun plazas/DM-26641-dos --id detector=180 --visit-pairs 3020090200313,3020090200314 3020090200316,3020090200317 3020090200343,3020090200344 3020090200319,3020090200320 3020090200346,3020090200347 3020090200322,3020090200323 3020090200349,3020090200350 3020090200325,3020090200326 3020090200352,3020090200353 3020090200328,3020090200329 3020090200355,3020090200356 3020090200331,3020090200332 3020090200358,3020090200359 3020090200334,3020090200335 3020090200361,3020090200362 3020090200337,3020090200338 3020090200364,3020090200365 3020090200340,3020090200341 3020090200367,3020090200368 3020090200370,3020090200371 -c maxMeanSignal=100000 ptcFitType=EXPAPPROXIMATION --clobber-config --clobber-versions -j 1
            

            plotPhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/plazas/DM-26616-dos --id detector=10 -c datasetFileName=/project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543/rerun/plazas/DM-26641-dos/calibrations/ptc/ptcDataset-det180.pkl --clobber-versions --clobber-config -j 1
            

            Plots: PTC_det10_2020SEP09.pdf

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - If all the points in an amp are bad, continue. measurePhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun plazas/DM-26641-dos --id detector=180 --visit-pairs 3020090200313,3020090200314 3020090200316,3020090200317 3020090200343,3020090200344 3020090200319,3020090200320 3020090200346,3020090200347 3020090200322,3020090200323 3020090200349,3020090200350 3020090200325,3020090200326 3020090200352,3020090200353 3020090200328,3020090200329 3020090200355,3020090200356 3020090200331,3020090200332 3020090200358,3020090200359 3020090200334,3020090200335 3020090200361,3020090200362 3020090200337,3020090200338 3020090200364,3020090200365 3020090200340,3020090200341 3020090200367,3020090200368 3020090200370,3020090200371 -c maxMeanSignal=100000 ptcFitType=EXPAPPROXIMATION --clobber-config --clobber-versions -j 1 plotPhotonTransferCurve.py /project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543 --rerun /project/shared/BOT/rerun/plazas/DM-26616-dos --id detector=10 -c datasetFileName=/project/shared/BOT/rerun/cslage/PTC_LSSTCAM_12543/rerun/plazas/DM-26641-dos/calibrations/ptc/ptcDataset-det180.pkl --clobber-versions --clobber-config -j 1 Plots: PTC_det10_2020SEP09.pdf
            Hide
            czw Christopher Waters added a comment -

            A few comments on the PR.

            Show
            czw Christopher Waters added a comment - A few comments on the PR.
            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32608/pipeline

              People

              Assignee:
              plazas Andrés Alejandro Plazas Malagón
              Reporter:
              cslage Craig Lage
              Reviewers:
              Christopher Waters
              Watchers:
              Andrés Alejandro Plazas Malagón, Christopher Waters, Craig Lage
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: