Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26654

insertFakes cleanCat() may clean stars without bulge/disk values

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/insertFakes.py#L683 seems like it also needs (fakeCat[self.config.sourceType] == starCheckVal) like the Sersic test below.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          sophiereed Sophie Reed added a comment -

          Thank you for catching this! It should be fixed now and Jenkins is running.

           

          Show
          sophiereed Sophie Reed added a comment - Thank you for catching this! It should be fixed now and Jenkins is running.  
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          That's a lot of parentheses, but it makes it clear what's going on.

          Looks fine.

          The only other thoughts I had were: 1) it would be nice to have tests that would pick this up and 2) if there are more conditions added in the future, it might be good to pull the star test out into its own if statement.

          Show
          ktl Kian-Tat Lim added a comment - That's a lot of parentheses, but it makes it clear what's going on. Looks fine. The only other thoughts I had were: 1) it would be nice to have tests that would pick this up and 2) if there are more conditions added in the future, it might be good to pull the star test out into its own if statement.

            People

            Assignee:
            sophiereed Sophie Reed
            Reporter:
            ktl Kian-Tat Lim
            Reviewers:
            Kian-Tat Lim
            Watchers:
            Kian-Tat Lim, Sophie Reed
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.