Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26673

Update matching routine to handle string columns

    XMLWordPrintable

    Details

      Description

      The current matching routine in faro cannot have string-valued columns. Update it to make this possible, so we can include things like filter names in the matched catalogs.

        Attachments

          Issue Links

            Activity

            No builds found.
            jcarlin Jeffrey Carlin created issue -
            jcarlin Jeffrey Carlin made changes -
            Field Original Value New Value
            Epic Link DM-24624 [ 433983 ]
            jcarlin Jeffrey Carlin made changes -
            Link This issue blocks DM-26674 [ DM-26674 ]
            lguy Leanne Guy made changes -
            Epic Link DM-24624 [ 433983 ] DM-26993 [ 440193 ]
            Hide
            jcarlin Jeffrey Carlin added a comment -

            Simon Krughoff Is this something we still need to do? For now we've implemented (see DM-26674 and this commit) the workaround of assigning numerical codes to filters in a dict, and other metadata such as visit and ccd can be passed as ints as well.

            I'm inclined to close this as "Won't Fix", but am interested to hear your thoughts.

            Show
            jcarlin Jeffrey Carlin added a comment - Simon Krughoff Is this something we still need to do? For now we've implemented (see DM-26674 and this commit ) the workaround of assigning numerical codes to filters in a dict, and other metadata such as visit and ccd can be passed as ints as well. I'm inclined to close this as "Won't Fix", but am interested to hear your thoughts.
            ctslater Colin Slater made changes -
            Labels sst-metrics
            lguy Leanne Guy made changes -
            Description The current matching routine in metric-pipeline-tasks cannot have string-valued columns. Update it to make this possible, so we can include things like filter names in the matched catalogs. The current matching routine in faro cannot have string-valued columns. Update it to make this possible, so we can include things like filter names in the matched catalogs.
            Hide
            lguy Leanne Guy added a comment -

            If the current workaround is doing what we need, I'd like to de-prioritise this. Simon Krughoff Jeffrey Carlin?

            Show
            lguy Leanne Guy added a comment - If the current workaround is doing what we need, I'd like to de-prioritise this. Simon Krughoff Jeffrey Carlin ?
            lguy Leanne Guy made changes -
            Epic Link DM-26993 [ 440193 ]
            lguy Leanne Guy made changes -
            Epic Link DM-29525 [ 465925 ]
            Hide
            lguy Leanne Guy added a comment -

            No longer relevant 

            Show
            lguy Leanne Guy added a comment - No longer relevant 
            lguy Leanne Guy made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Won't Fix [ 10405 ]

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              jcarlin Jeffrey Carlin
              Watchers:
              Jeffrey Carlin, Leanne Guy
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.