Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26811

Make the obs_lsst imSim instrument name respect the case of the imSim program name.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Architecture

      Description

      imSim starts with a lower case "i". In fact there is a different "ImSim" from a very long time ago which was a description sometimes used for the suite of many simulation programs including PhoSim etc. However as can be seen at its GitHub page:

      https://github.com/LSSTDESC/imSim

      The imSim program we are using now, uses lower case. Due to necessities of CamelCase the internal Python class names used for the instrument takes the form XxxxImSimYyyy.

      The instruments names were copied from this convention and thus now look like

      LSST-ImSim

      However, with the "-", I would like to request we use the proper capitalization for the imSim instrument names.

      You can see the instances of the name here:

      https://github.com/lsst/obs_lsst/search?q=LSST-ImSim&unscoped_q=LSST-ImSim

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          To be absolutely clear: you are okay with LSST-imSim? You could also be LSSTCam-imSim if you prefer.

          Show
          tjenness Tim Jenness added a comment - To be absolutely clear: you are okay with LSST-imSim ? You could also be LSSTCam-imSim if you prefer.
          Hide
          cwalter Chris Walter added a comment -

          Oh, interesting.. I didn't appreciate that was an option.

          What will the real camera be? I don't see a header file in the lsstCam policy directory.

          Show
          cwalter Chris Walter added a comment - Oh, interesting.. I didn't appreciate that was an option. What will the real camera be? I don't see a header file in the lsstCam policy directory.
          Hide
          tjenness Tim Jenness added a comment -

          I'm calling the real camera LSSTCam

          Show
          tjenness Tim Jenness added a comment - I'm calling the real camera LSSTCam
          Hide
          cwalter Chris Walter added a comment -

          OK in that case I think LSSTCam-imSim would indeed probably be better. If we ever did ComCam, AuxTel or something else it would make more sense. Thanks for pointing that out.

          Show
          cwalter Chris Walter added a comment - OK in that case I think LSSTCam-imSim would indeed probably be better. If we ever did ComCam, AuxTel or something else it would make more sense. Thanks for pointing that out.
          Hide
          tjenness Tim Jenness added a comment -

          Chris Walter the change was fairly simple. I changed phosim to LSSTCam-PhoSim for consistency (cc/ Simon Krughoff in case that's a problem). Note that this will affect any existing imsim and phosim gen3 repositories which will need to be rebuilt (the instrument name is a primary key) and any metadata corrections files will need to be rebuilt.

          cc/ Dominique Boutigny and James Chiang.

          Show
          tjenness Tim Jenness added a comment - Chris Walter the change was fairly simple. I changed phosim to LSSTCam-PhoSim for consistency (cc/ Simon Krughoff in case that's a problem). Note that this will affect any existing imsim and phosim gen3 repositories which will need to be rebuilt (the instrument name is a primary key) and any metadata corrections files will need to be rebuilt. cc/ Dominique Boutigny and James Chiang .
          Hide
          tjenness Tim Jenness added a comment -

          Chris Walter reviewed this on GitHub.

          Show
          tjenness Tim Jenness added a comment - Chris Walter reviewed this on GitHub.

            People

            Assignee:
            tjenness Tim Jenness
            Reporter:
            cwalter Chris Walter
            Reviewers:
            Chris Walter
            Watchers:
            Chris Walter, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.