Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26874

rename pipetask2 to pipetask, remove old pipetask

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      DB_F20_09
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      Includes removing now-unused old-pipetask code.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Nate Pease [X] can we bump the priority on this please? The longer we go without people using the new version the more chance we have of finding problems earlier rather than waiting until November.

            Show
            tjenness Tim Jenness added a comment - Nate Pease [X] can we bump the priority on this please? The longer we go without people using the new version the more chance we have of finding problems earlier rather than waiting until November.
            Hide
            npease Nate Pease [X] (Inactive) added a comment -

            ok

            Show
            npease Nate Pease [X] (Inactive) added a comment - ok
            Hide
            npease Nate Pease [X] (Inactive) added a comment - - edited

            pipetask had options `-i/\–-input and -o/--output, but -i conflicted with butler's -i/--instrument, so I removed the -i from --input. Assuming that's what we want, does it make sense to leave the -o flag for --output? I think it may be confusing to have that but to have -i mean something other than input. Or, I could change the --instrument short flag, but that might be a bigger change than we want?

            Show
            npease Nate Pease [X] (Inactive) added a comment - - edited pipetask had options `-i/\–-input and -o/--output , but -i conflicted with butler 's -i/--instrument , so I removed the -i  from --input . Assuming that's what we want, does it make sense to leave the -o flag for --output ? I think it may be confusing to have that but to have -i  mean something other than input. Or, I could change the --instrument short flag, but that might be a bigger change than we want?
            Hide
            npease Nate Pease [X] (Inactive) added a comment -

            Andy can you please review these changes?

            Pending the answer to the question about the -o flag, there maybe a bit more work to do for this ticket if we decide to not use -o for --output (or change --instrument's -i).

            Show
            npease Nate Pease [X] (Inactive) added a comment - Andy can you please review these changes? Pending the answer to the question about the -o flag, there maybe a bit more work to do for this ticket if we decide to not use -o for --output (or change --instrument's -i).
            Hide
            salnikov Andy Salnikov added a comment -

            Looks OK, though I have a concern for --long-log which is now a global option. For old pipetask we specifically decided that all options have to be per-sub-command options to avoid confusion.

            Show
            salnikov Andy Salnikov added a comment - Looks OK, though I have a concern for --long-log which is now a global option. For old pipetask we specifically decided that all options have to be per-sub-command options to avoid confusion.
            Hide
            salnikov Andy Salnikov added a comment -

            Old pipetask had only long option for an instrument, and short -i option for --input. We could keep that convention or add short -I (capital) for an instrument (and I know all reasons why capital I is bad).

            Show
            salnikov Andy Salnikov added a comment - Old pipetask had only long option for an instrument, and short -i option for --input. We could keep that convention or add short -I (capital) for an instrument (and I know all reasons why capital I is bad).
            Hide
            npease Nate Pease [X] (Inactive) added a comment -

            Of course that would still be inconsistent with the butler command, which we are trying to avoid.

            Show
            npease Nate Pease [X] (Inactive) added a comment - Of course that would still be inconsistent with the butler command, which we are trying to avoid.
            Hide
            salnikov Andy Salnikov added a comment -

            Well, pipetask is going to be used much more frequently than butler and in that respect consistency between -i and -o in pipetask is more important than consistency for -i between pipetask and butler.

            Show
            salnikov Andy Salnikov added a comment - Well, pipetask is going to be used much more frequently than butler and in that respect consistency between -i and -o in pipetask is more important than consistency for -i between pipetask and butler.

              People

              Assignee:
              npease Nate Pease [X] (Inactive)
              Reporter:
              npease Nate Pease [X] (Inactive)
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Nate Pease [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.