Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26943

Support newer headers in imsim data

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      From discussion on DM-26937 I learned that the newer imsim data have an AIRMASS header (and AMSTART). Use that header in the translator and only use the altaz values if the header is missing.

      I don't think this change will speed up DM-26937 because the altaz has to be calculated anyhow for the zenith angle.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Great. I'll fix up my change to use degrees.

            Show
            tjenness Tim Jenness added a comment - Great. I'll fix up my change to use degrees.
            Hide
            tjenness Tim Jenness added a comment -

            Eric Neilsen thanks for the review on GitHub. If no-one suggests any more tweaks from the new headers I will formally put the jira ticket in review and we can merge this week.

            Show
            tjenness Tim Jenness added a comment - Eric Neilsen thanks for the review on GitHub. If no-one suggests any more tweaks from the new headers I will formally put the jira ticket in review and we can merge this week.
            Hide
            tjenness Tim Jenness added a comment -

            Eric Neilsen if there are no other changes needed for newer headers can you please formally review this ticket in Jira so I can merge.

            Show
            tjenness Tim Jenness added a comment - Eric Neilsen if there are no other changes needed for newer headers can you please formally review this ticket in Jira so I can merge.
            Hide
            neilsen Eric Neilsen added a comment -

            Looks good.

            Show
            neilsen Eric Neilsen added a comment - Looks good.
            Hide
            tjenness Tim Jenness added a comment -

            Thanks. If this is still a hotspot we'll have to add the AZSTART and ELSTART headers to the DC2 data.

            Show
            tjenness Tim Jenness added a comment - Thanks. If this is still a hotspot we'll have to add the AZSTART and ELSTART headers to the DC2 data.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Eric Neilsen
              Watchers:
              Eric Neilsen, Hsin-Fang Chiang, James Chiang, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.