Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26944

Move certifyCalibrations.py content to a butler command

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Team:
      Data Release Production

      Description

      With a near-final butler way to handle calibration certification, we can move the majority of code from the bin.src script to the python directory.

        Attachments

          Issue Links

          is blocked by

          Technical task - Created by JIRA Agile - do not edit or delete. Issue type for a technical task. DM-26629 Convert calibration datasets to use CALIBRATION collections instead of calibration_label

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I've reviewed the code on GitHub but I have a more general problem that this is three lines of completely generic butler code and I can't understand why it's not a butler command.

            cc/ Jim Bosch

            Show
            tjenness Tim Jenness added a comment - I've reviewed the code on GitHub but I have a more general problem that this is three lines of completely generic butler code and I can't understand why it's not a butler command. cc/ Jim Bosch
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I have no problem with it being moved to a butler command.  It's not already due to the need to have a way to do this step before the current gen3 butler commands were available.

            Show
            czw Christopher Waters added a comment - I have no problem with it being moved to a butler command.  It's not already due to the need to have a way to do this step before the current gen3 butler commands were available.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Ok. Moving it should not be much work at all. You'd need to add a stub to python/lsst/daf/butler/cli/cmd/commands.py and your implementation code to python/lsst/daf/butler/script/certifyCalibration.py

            Show
            tjenness Tim Jenness added a comment - Ok. Moving it should not be much work at all. You'd need to add a stub to python/lsst/daf/butler/cli/cmd/commands.py and your implementation code to python/lsst/daf/butler/script/certifyCalibration.py
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            No objection from me, either. I just didn't want to add any more scope at all to what was already a huge ticket landing right before a weekly when I converted this to Gen3 internally.

            Show
            jbosch Jim Bosch added a comment - No objection from me, either. I just didn't want to add any more scope at all to what was already a huge ticket landing right before a weekly when I converted this to Gen3 internally.
            Hide
            Permalink
            czw Christopher Waters added a comment -

            I'm unclear why the third branch (daf_butler) isn't showing up.  Here's the PR: https://github.com/lsst/daf_butler/pull/407

            Jenkins build so I don't lose it: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32924/pipeline

            Show
            czw Christopher Waters added a comment - I'm unclear why the third branch (daf_butler) isn't showing up.  Here's the PR:  https://github.com/lsst/daf_butler/pull/407 Jenkins build so I don't lose it:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32924/pipeline
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good. Minor comments on documentation.

            I also wonder about the time arguments but I think we can stick with ISO and add MJD later if needed.

            Show
            tjenness Tim Jenness added a comment - Looks good. Minor comments on documentation. I also wonder about the time arguments but I think we can stick with ISO and add MJD later if needed.

              People

              Assignee:
              czw Christopher Waters
              Reporter:
              czw Christopher Waters
              Reviewers:
              Tim Jenness
              Watchers:
              Christopher Waters, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.