Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26953

Update ap_verify system for calibration collections

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      AP F20-4 (September), AP F20-5 (October)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      The Gen 3 Middleware changes introduced in w_2020_39, particularly calibration collections, have broken the Gen 3 code in ap_verify (particularly how it handles repository abstraction). Iterate between updates to ap_verify_ci_hits2015 and ap_verify_ci_cosmos_pdr2 and to ap_verify's drivers until everything works in at least HSC.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27018 Fix problems with inconsistencies in calibrations gaps in gen2 to 3 conversion

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-26947 Minor follow-up work from DM-26629

          • Done

          Technical task - Created by JIRA Agile - do not edit or delete. Issue type for a technical task. DM-26629 Convert calibration datasets to use CALIBRATION collections instead of calibration_label

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            krzys Krzysztof Findeisen created issue -
            krzys Krzysztof Findeisen made changes -
            Field Original Value New Value
            Epic Link DM-26810 [ 439762 ]
            krzys Krzysztof Findeisen made changes -
            Description Following a large number of changes to the Gen 3 Middleware, rebuild and test the Gen 3 repositories in {{ap_verify_ci_cosmos_pdr2}} and {{ap_verify_ci_hits2015}} against {{w_39}}. Following a large number of changes to the Gen 3 Middleware, rebuild and test the Gen 3 repositories in {{ap_verify_ci_cosmos_pdr2}} and {{ap_verify_ci_hits2015}} against {{w_2020_39}}.
            krzys Krzysztof Findeisen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            krzys Krzysztof Findeisen made changes -
            Labels gen3-middleware
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            This issue has scope-creeped quite a bit, as it turns out that DM-26629 broke some of the assumptions made by ap_verify, so it's not possible to test the repositories without substantial code changes. I've revised this issue accordingly.

            Show
            krzys Krzysztof Findeisen added a comment - This issue has scope-creeped quite a bit, as it turns out that DM-26629 broke some of the assumptions made by ap_verify , so it's not possible to test the repositories without substantial code changes. I've revised this issue accordingly.
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-26947 [ DM-26947 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-26629 [ DM-26629 ]
            krzys Krzysztof Findeisen made changes -
            Story Points 1 4
            Description Following a large number of changes to the Gen 3 Middleware, rebuild and test the Gen 3 repositories in {{ap_verify_ci_cosmos_pdr2}} and {{ap_verify_ci_hits2015}} against {{w_2020_39}}. The Gen 3 Middleware changes introduced in {{w_2020_39}}, particularly calibration collections, have broken the Gen 3 code in {{ap_verify}} (particularly how it handles repository abstraction). Iterate between updates to {{ap_verify_ci_hits2015}} and {{ap_verify_ci_cosmos_pdr2}} and to {{ap_verify's}} drivers until everything works in at least HSC.
            Summary Update CI repositories for latest Butler Update ap_verify system for calibration collections
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-27018 [ DM-27018 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Since conversion of HiTS is blocked on DM-27018 but we can't run it in Gen 3 anyway (DM-23985), I'm pushing just the Cosmos dataset for now.

            Jim Bosch, can you take a look at the code changes here? I don't think there's any point to looking at the Cosmos repository, as it's mostly file moves and a registry rewrite.

            Show
            krzys Krzysztof Findeisen added a comment - Since conversion of HiTS is blocked on DM-27018 but we can't run it in Gen 3 anyway ( DM-23985 ), I'm pushing just the Cosmos dataset for now. Jim Bosch , can you take a look at the code changes here? I don't think there's any point to looking at the Cosmos repository, as it's mostly file moves and a registry rewrite.
            krzys Krzysztof Findeisen made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            sullivan Ian Sullivan made changes -
            Sprint AP F20-4 (September) [ 1039 ] AP F20-4 (September), AP F20-5 (October) [ 1039, 1046 ]
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good! Just one tiny comment-on-a-comment.

            Show
            jbosch Jim Bosch added a comment - Looks good! Just one tiny comment-on-a-comment.
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krzys Krzysztof Findeisen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.