Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: DM Subsystem Science
-
Labels:
-
Epic Link:
-
Team:DM Science
-
Urgent?:No
Description
The way filterMatches.py is working it throws out the entire group of matched sources when any of them is flagged. We need to change the filtering to happen on the individual source measurements, rather than the entire group.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
Colin Slater
made changes -
| Labels | sst-metrics |
| Assignee | Jeffrey Carlin [ jcarlin ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Colin Slater
made changes -
| Labels | sst-metrics | backport-v23 sst-metrics |
| Reviewers | Colin Slater [ ctslater ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
A note for the future: an error in building/running ci_hsc_gen3 was difficult to track down. The issue was that we needed to add the new matched catalog datasets to pipelines/HSC/DRP-RC2.yaml from drp_pipe that is imported by ci_hsc_gen3. Even though the pipeline in ci_hsc_gen3 excludes almost all of the faro steps, the fact that they were not added explicitly to the faro_step3 and faro_step5 subsets meant that the new dataset types were not getting excluded. The solution was to add them to those subsets in the "default" pipelines, so they'll be part of the list that is excluded from consideration.
| Description | The way `filterMatches.py` is working it throws out the entire group of matched sources when _any_ of them is flagged. We need to change the filtering to happen on the individual source measurements, rather than the entire group. | The way {{filterMatches.py}} is working it throws out the entire group of matched sources when _any_ of them is flagged. We need to change the filtering to happen on the individual source measurements, rather than the entire group. |
Good find on that convoluted ci_hsc issue.
Colin Slater
added a comment - Good find on that convoluted ci_hsc issue. Colin Slater
made changes -
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
This turned out to require updates to drp_pipe as well. The Jenkins build with changes to both packages was successful.