Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2699

Final cleanup of Query cancellation code

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      The query cancellation code that went in through DM-1716 works fine, however we feel it'd be good to do another pass and double check we are applying the cancellation consistently. Some potential places to clean:
      1. in ccontrol/UserQuery.cc we changed the semantics of discard()
      2. QueryRequest needs some cleanup: it'd be better to call Finished() from one place

      More regarding the former (from DM-1716 PR): "if a query is cancelled, none of the cleanup below happens in discard() anymore – presumably we are now waiting for object deletion to do the cleanup.

      If object deletion is sufficient to do this cleanup, do we need discard() at all anymore? It would be best if cleanup always occured in the same place rather than having two different control paths for it?"

      Regarding the latter - see comment in https://jira.lsstcorp.org/browse/DM-1716

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  jgates John Gates
                  Reporter:
                  fritzm Fritz Mueller
                  Reviewers:
                  Andy Salnikov, Fritz Mueller
                  Watchers:
                  Andy Salnikov, Fritz Mueller, Jacek Becla, John Gates
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel