This ticket replaces the former useUpdatedCalibs config option with two new flags: doApplyExternalSkyWcs and doApplyExternalPhotoCalib. An additional two fields (externalSkyWcsName and externalPhotoCalibName) allow the user to specify the type of sky WCS (currently only one option) and photometric calibration they wish to use. The changes made here are logical, and bring the code in line with updates elsewhere in the stack. From a readability perspective, it would be nice if the config options in the config class were in a more logical order, e.g.: doApplyExternalSkyWcs; externalSkyWcsName; doApplyExternalPhotoCalib; externalPhotoCalibName. Other than that, this looks great, nicely done!

This is an example test output I made using this ticket branch for Tract 9813 Patch 5,5. As shown, relative to the vanilla patch, fake sources are being successfully injected using the updated FGCM photometric calibration setup.

This is an example test output using this ticket branch for Visit 1228. On the whole, the visit looks fine. However, two CCDs (95 and 103 I think) are slightly off when it comes to the difference plot. I don't think this is related to any changes made for this ticket, but good to highlight nonetheless.

Update: reviewed again following further changes. Looks good, but I still recommend re-ordering the config options as mentioned above.