Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-26999

Update fakes insertion code with an option to use fgcm.

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 4
    • DRP F20-3 (Aug), DRP F20-5 (Oct)
    • Data Release Production
    • No

    Description

      The rest of the stack now can use fcgm for calibration, the fakes insertion code has fallen behind in these calibration updates. Add a config option that allows the user to specify their preferred calibration type.

      Attachments

        Issue Links

          Activity

            No builds found.
            sophiereed Sophie Reed created issue -
            sophiereed Sophie Reed made changes -
            Field Original Value New Value
            Epic Link DM-26790 [ 439740 ]
            sophiereed Sophie Reed made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            sophiereed Sophie Reed made changes -
            Story Points 2 4
            sophiereed Sophie Reed made changes -
            Reviewers Lee Kelvin [ lskelvin ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            lskelvin Lee Kelvin added a comment -

            This ticket replaces the former useUpdatedCalibs config option with two new flags: doApplyExternalSkyWcs and doApplyExternalPhotoCalib. An additional two fields (externalSkyWcsName and externalPhotoCalibName) allow the user to specify the type of sky WCS (currently only one option) and photometric calibration they wish to use. The changes made here are logical, and bring the code in line with updates elsewhere in the stack. From a readability perspective, it would be nice if the config options in the config class were in a more logical order, e.g.: doApplyExternalSkyWcs; externalSkyWcsName; doApplyExternalPhotoCalib; externalPhotoCalibName. Other than that, this looks great, nicely done!

            lskelvin Lee Kelvin added a comment - This ticket replaces the former useUpdatedCalibs config option with two new flags: doApplyExternalSkyWcs and doApplyExternalPhotoCalib . An additional two fields ( externalSkyWcsName and externalPhotoCalibName ) allow the user to specify the type of sky WCS (currently only one option) and photometric calibration they wish to use. The changes made here are logical, and bring the code in line with updates elsewhere in the stack. From a readability perspective, it would be nice if the config options in the config class were in a more logical order, e.g.: doApplyExternalSkyWcs ; externalSkyWcsName ; doApplyExternalPhotoCalib ; externalPhotoCalibName . Other than that, this looks great, nicely done!
            lskelvin Lee Kelvin made changes -
            Attachment fgcmRun-t9813p55.png [ 45641 ]
            lskelvin Lee Kelvin added a comment -

            This is an example test output I made using this ticket branch for Tract 9813 Patch 5,5. As shown, relative to the vanilla patch, fake sources are being successfully injected using the updated FGCM photometric calibration setup.

            lskelvin Lee Kelvin added a comment - This is an example test output I made using this ticket branch for Tract 9813 Patch 5,5. As shown, relative to the vanilla patch, fake sources are being successfully injected using the updated FGCM photometric calibration setup.
            lskelvin Lee Kelvin made changes -
            Attachment fgcmRun-v1228.png [ 45642 ]
            lskelvin Lee Kelvin added a comment -

            This is an example test output using this ticket branch for Visit 1228. On the whole, the visit looks fine. However, two CCDs (95 and 103 I think) are slightly off when it comes to the difference plot. I don't think this is related to any changes made for this ticket, but good to highlight nonetheless.

            lskelvin Lee Kelvin added a comment - This is an example test output using this ticket branch for Visit 1228. On the whole, the visit looks fine. However, two CCDs (95 and 103 I think) are slightly off when it comes to the difference plot. I don't think this is related to any changes made for this ticket, but good to highlight nonetheless.
            lskelvin Lee Kelvin added a comment -

            Update: reviewed again following further changes. Looks good, but I still recommend re-ordering the config options as mentioned above.

            lskelvin Lee Kelvin added a comment - Update: reviewed again following further changes. Looks good, but I still recommend re-ordering the config options as mentioned above.
            lskelvin Lee Kelvin made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            yusra Yusra AlSayyad made changes -
            Sprint DRP F20-3 (Aug) [ 1042 ] DRP F20-3 (Aug), DRP F20-5 (Oct) [ 1042, 1054 ]
            sophiereed Sophie Reed made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            lskelvin Lee Kelvin made changes -
            Link This issue relates to DM-27361 [ DM-27361 ]

            People

              sophiereed Sophie Reed
              sophiereed Sophie Reed
              Lee Kelvin
              Lee Kelvin, Sophie Reed, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.