Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27013

Change CalibrateTask refcat defaults to Gaia DR2 for astrometry and PS1 for photometry

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      AP S22-3 (February), AP S22-4 (March), AP S22-5 (April)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      This is the implementation ticket for RFC-697, to update the CalibrateTask reference catalog defaults to use Gaia DR2 for astrometry and PS1 for photometry and remove relevant overrides from obs packages. These are the defaults that we want, although exactly how to implement them (probably inside CalibrateConfig.setDefaults()?):

      astromRefObjLoader.ref_dataset_name = "gaia_dr2_20200414"
      		 
      astromRefObjLoader.anyFilterMapsToThis = "phot_g_mean"
      		 
      photoRefObjLoader.ref_dataset_name = "ps1_pv3_3pi_20170110"

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33058 Deprecate validation_data_hsc and validation_data_decam

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-697 Change CalibrateTask refcat defaults to Gaia DR2 for astrometry and PS1 for photometry

          • Implemented
          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-34491 DM-27013 broke ap_verify runs

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27858 Validate new Gaia AstrometryTask defaults for HSC

          • To Do
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34752 Move non-generic characterize/calibrate configs out of obs_lsst/config

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-25316 Apply proper motion in AstrometryTask when loading refcats

          • Invalid
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            14 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            DM-27858 is the relevant ticket for validating the HSC changes. I don't know who is going to be responsible for that, but I'll bring it up on slack.

            Show
            Parejkoj John Parejko added a comment - DM-27858 is the relevant ticket for validating the HSC changes. I don't know who is going to be responsible for that, but I'll bring it up on slack.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thank you Lee Kelvin for investigating this ticket on DECam. I've merged all the branches, but closed the obs_subaru PR without merging it.

            Show
            Parejkoj John Parejko added a comment - Thank you Lee Kelvin for investigating this ticket on DECam. I've merged all the branches, but closed the obs_subaru PR without merging it.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I neglected to re-run Jenkins after rebasing everything, and my merge broke the ap_verify package. I've put a fix for that on tickets/DM-27013-fix, but there is apparently a separate breakage when running ap_verify; I filed DM-34491 for that one.

            Show
            Parejkoj John Parejko added a comment - I neglected to re-run Jenkins after rebasing everything, and my merge broke the ap_verify package. I've put a fix for that on tickets/ DM-27013 -fix , but there is apparently a separate breakage when running ap_verify; I filed DM-34491 for that one.
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Thanks for the update John. For completeness, the fix PR is at this link.

            Show
            lskelvin Lee Kelvin added a comment - Thanks for the update John. For completeness, the fix PR is at this link .
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            And one final PR to fix a pipelines_check breakage that was masked by the unmerged obs_subaru branch: https://github.com/lsst/obs_subaru/pull/416

            Show
            Parejkoj John Parejko added a comment - And one final PR to fix a pipelines_check breakage that was masked by the unmerged obs_subaru branch: https://github.com/lsst/obs_subaru/pull/416

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Lee Kelvin
              Watchers:
              Ian Sullivan, John Parejko, Krzysztof Findeisen, Lauren MacArthur, Lee Kelvin, Meredith Rawls, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.