Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:0.7
-
Epic Link:
-
Team:SQuaRE
-
Urgent?:No
Description
I just ran the template package (fresh git pull of master) to make a roundtable_aiohttp_bot app and ran into a few small issues:
- src/<name>/__init__.py adds "metadata" to __all__ but that symbol does not exist.
- There is an if statement based on Python version, but the two cases are identical (not a bug, but please consider simplifying the file to remove this).
- src/<name>/handlers/__init__.py adds "init_routes" to __all__ but that symbol does not exist.
I also see these issues in segwarides yet it runs, so maybe the two things I think are bugs are not. If they actually work then a brief comment explaining what is going on in the generated files would be appreciated. Certainly they make flake8 very unhappy.
Finally: the newly created files could not be committed because isort said some imports were out of order.
I used the package name "owl" in case that makes a difference.
Russell Owen, I'll make the fixes, in the meantime:
For #1, feel free to remove that metadata; that was missed from previous changes to the template.
For #2, they are different lines, but if you're only developing on Python 3.8 you don't need the backport package ( importlib_metadata ).
For #3, again feel free to remove the init_routes from }}{{_all_.