Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ap_verify
-
Story Points:4
-
Epic Link:
-
Sprint:AP F20-5 (October)
-
Team:Alert Production
-
Urgent?:No
Description
In Gen 3 mode, ap_verify relies on ctrl_mpexec for running the AP pipeline, but there is as yet no API to support pipeline execution from within a larger program (DM-26239). ap_verify hacked around this by calling CmdLineFwk's command-line parser, but this code was removed in DM-26874.
Following discussion on #dm-middleware, attempt to use click.testing.CliRunner as an almost-drop-in replacement for CmdLineFwk.parseAndRun. If this breaks important pipeline features (parallelism, logging, etc.), fall back to manually calling the scripts at https://github.com/lsst/ctrl_mpexec/tree/master/python/lsst/ctrl/mpexec/cli/script.
Attachments
Issue Links
Activity
CliRunner seems to work fine; all expected logs appear on the terminal and there aren't any (obvious) concurrency problems.
Krzysztof Findeisen
added a comment - CliRunner seems to work fine; all expected logs appear on the terminal and there aren't any (obvious) concurrency problems. Nate Pease [X], would you be willing to review this?
I ended up deferring the testing question to DM-27117, since it would involve a significant rewrite of the existing tests. However, this means for that now the main Gen 3 thing that is still covered in ap_verify's unit tests is importability.
Krzysztof Findeisen
added a comment - Nate Pease [X] , would you be willing to review this?
I ended up deferring the testing question to DM-27117 , since it would involve a significant rewrite of the existing tests. However, this means for that now the main Gen 3 thing that is still covered in ap_verify 's unit tests is importability. looks good.
If time permits, consider changing test_driver.py to mock only at lower levels; previously, all of CmdLineFwk was replaced with a mock, which is why the problem didn't get caught in unit tests.