Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27103

Not all IsrCalib tests round trip calibrations

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      I was inconsistent with writing round-trip tests for calibrations, and this ticket is the clean-up to fix that.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          czw Christopher Waters added a comment -

          Only crosstalk was found missing a round-trip testing case.  That's been fixed now.

          This also fixes the problems those tests identified in the crosstalk calibration.

          I've also updated the IsrCalib._eq_ method to reduce code duplication.

          Show
          czw Christopher Waters added a comment - Only crosstalk was found missing a round-trip testing case.  That's been fixed now. This also fixes the problems those tests identified in the crosstalk calibration. I've also updated the IsrCalib._ eq _ method to reduce code duplication.
          Hide
          Permalink
          czw Christopher Waters added a comment - - edited

          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33946/pipeline

          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33991/pipeline

          Show
          czw Christopher Waters added a comment - - edited https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33946/pipeline https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33991/pipeline
          Hide
          Permalink
          plazas Andrés Alejandro Plazas Malagón added a comment -

          Looks good, just two minor questions asking for clarification.

          Show
          plazas Andrés Alejandro Plazas Malagón added a comment - Looks good, just two minor questions asking for clarification.

            People

            Assignee:
            czw Christopher Waters
            Reporter:
            czw Christopher Waters
            Reviewers:
            Andrés Alejandro Plazas Malagón
            Watchers:
            Andrés Alejandro Plazas Malagón, Christopher Waters
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.