Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27170

Deprecate and phase out afw::image::Filter

    XMLWordPrintable

    Details

    • Story Points:
      20
    • Sprint:
      AP S21-1 (December), AP S21-2 (January)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Deprecate lsst::afw::image::Filter in favor of lsst::afw::image::FilterLabel, as well as all functions and methods that refer to it in their interface. Replace references to Filter in the lsst organization with FilterLabel.

      If a replacement of Filter with FilterLabel turns out to be nontrivial (as may be the case for its use in obs_base), open a new ticket for it.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment - - edited

            New new new jenkins run, after a happy ci_hsc_gen2 locally, a full set of rebasing, and a fixed deprecation notice: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33449/pipeline/

            Show
            Parejkoj John Parejko added a comment - - edited New new new jenkins run, after a happy ci_hsc_gen2 locally, a full set of rebasing, and a fixed deprecation notice: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33449/pipeline/
            Hide
            Parejkoj John Parejko added a comment -

            Yusra AlSayyad: Would you please look at the changes in pipe_tasks and obs_subaru? These should match what we worked together on yesterday (thank you so much for that!), but I'd like a double-check.

            Krzysztof Findeisen: Please have another look at pipe_tasks and obs_subaru: I think I cleaned up everything you mentioned, and a bunch more. Some of the obs_subaru work had to be pushed to DM-28334.

            pipe_tasks PR: https://github.com/lsst/pipe_tasks/pull/448
            obs_subaru PR: https://github.com/lsst/obs_subaru/pull/333

            NOTE: the Github CI failures are a known issue, and need to wait for a fix from Tim, which should happen later today.

            Show
            Parejkoj John Parejko added a comment - Yusra AlSayyad : Would you please look at the changes in pipe_tasks and obs_subaru? These should match what we worked together on yesterday (thank you so much for that!), but I'd like a double-check. Krzysztof Findeisen : Please have another look at pipe_tasks and obs_subaru: I think I cleaned up everything you mentioned, and a bunch more. Some of the obs_subaru work had to be pushed to DM-28334 . pipe_tasks PR: https://github.com/lsst/pipe_tasks/pull/448 obs_subaru PR: https://github.com/lsst/obs_subaru/pull/333 NOTE: the Github CI failures are a known issue, and need to wait for a fix from Tim, which should happen later today.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Looks good to me. Thank you for your patience with a very picky reviewer!

            Show
            krzys Krzysztof Findeisen added a comment - Looks good to me. Thank you for your patience with a very picky reviewer!
            Hide
            yusra Yusra AlSayyad added a comment -

            Copied and pasted from pipe_tasks:

            I only looked at the postprocessing stuff. As long as the transformSourceTable.py and transformObjectCatalog.py that we ran on Monday runs on your ci_hsc, fine with me.

            Show
            yusra Yusra AlSayyad added a comment - Copied and pasted from pipe_tasks: I only looked at the postprocessing stuff. As long as the transformSourceTable.py and transformObjectCatalog.py that we ran on Monday runs on your ci_hsc, fine with me.
            Hide
            Parejkoj John Parejko added a comment -

            Big thank you to Krzysztof Findeisen for the many reviews, and Yusra AlSayyad for helping me debug the final portion of this.

            15 PRs merged, and we're finally done!

            Show
            Parejkoj John Parejko added a comment - Big thank you to Krzysztof Findeisen for the many reviews, and Yusra AlSayyad for helping me debug the final portion of this. 15 PRs merged, and we're finally done!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Christopher Waters, Jim Bosch, John Parejko, Krzysztof Findeisen, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: