Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27170

Deprecate and phase out afw::image::Filter

    XMLWordPrintable

    Details

    • Story Points:
      20
    • Epic Link:
    • Sprint:
      AP S21-1 (December), AP S21-2 (January)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Deprecate lsst::afw::image::Filter in favor of lsst::afw::image::FilterLabel, as well as all functions and methods that refer to it in their interface. Replace references to Filter in the lsst organization with FilterLabel.

      If a replacement of Filter with FilterLabel turns out to be nontrivial (as may be the case for its use in obs_base), open a new ticket for it.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27177 Remove lsst.afw.image.Filter

          • Done
          has to be finished together with

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28487 Write Community post about Filter deprecation

          • Done
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-28236 get('calexp_filterLabel') does not return a full label for pre-FilterLabel data

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27168 Phase out use of FilterProperty

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27169 Use FilterLabel in Exposure/ExposureInfo

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-730 Replace afw.image.Filter with simple label-based classes

          • Implemented

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-748 Accelerated deprecation of Filter

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28088 Change fgcmcal to use FilterLabel

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28093 Change isrTask (and relevant configs) to use physicalLabel

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28334 makeTransmissionCurves needs to be updated to use physical filter names

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28503 Update schemas to use "band" when refering to band

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28577 Surpress Filter warnings in FilterDefinitions

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28583 Update fitsExposure formatter to fill in filterLabel from dataId

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28597 Fix colorterm/photoCal filterLabel confusion

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28693 Additional Filter deprecation warnings in lsstCamMapper

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28166 Update obs package use of filter.getId() in _computeCoaddExposureId

          • Won't Fix
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28727 Modernize pybind11 wrappers for afw.image

          • Done

            Activity

            Ascending order - Click to sort in descending order
            8 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            New new new jenkins run, after a happy ci_hsc_gen2 locally, a full set of rebasing, and a fixed deprecation notice: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33449/pipeline/

            Show
            Parejkoj John Parejko added a comment - - edited New new new jenkins run, after a happy ci_hsc_gen2 locally, a full set of rebasing, and a fixed deprecation notice: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33449/pipeline/
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Yusra AlSayyad: Would you please look at the changes in pipe_tasks and obs_subaru? These should match what we worked together on yesterday (thank you so much for that!), but I'd like a double-check.

            Krzysztof Findeisen: Please have another look at pipe_tasks and obs_subaru: I think I cleaned up everything you mentioned, and a bunch more. Some of the obs_subaru work had to be pushed to DM-28334.

            pipe_tasks PR: https://github.com/lsst/pipe_tasks/pull/448
            obs_subaru PR: https://github.com/lsst/obs_subaru/pull/333

            NOTE: the Github CI failures are a known issue, and need to wait for a fix from Tim, which should happen later today.

            Show
            Parejkoj John Parejko added a comment - Yusra AlSayyad : Would you please look at the changes in pipe_tasks and obs_subaru? These should match what we worked together on yesterday (thank you so much for that!), but I'd like a double-check. Krzysztof Findeisen : Please have another look at pipe_tasks and obs_subaru: I think I cleaned up everything you mentioned, and a bunch more. Some of the obs_subaru work had to be pushed to DM-28334 . pipe_tasks PR: https://github.com/lsst/pipe_tasks/pull/448 obs_subaru PR: https://github.com/lsst/obs_subaru/pull/333 NOTE: the Github CI failures are a known issue, and need to wait for a fix from Tim, which should happen later today.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good to me. Thank you for your patience with a very picky reviewer!

            Show
            krzys Krzysztof Findeisen added a comment - Looks good to me. Thank you for your patience with a very picky reviewer!
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Copied and pasted from pipe_tasks:

            I only looked at the postprocessing stuff. As long as the transformSourceTable.py and transformObjectCatalog.py that we ran on Monday runs on your ci_hsc, fine with me.

            Show
            yusra Yusra AlSayyad added a comment - Copied and pasted from pipe_tasks: I only looked at the postprocessing stuff. As long as the transformSourceTable.py and transformObjectCatalog.py that we ran on Monday runs on your ci_hsc, fine with me.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Big thank you to Krzysztof Findeisen for the many reviews, and Yusra AlSayyad for helping me debug the final portion of this.

            15 PRs merged, and we're finally done!

            Show
            Parejkoj John Parejko added a comment - Big thank you to Krzysztof Findeisen for the many reviews, and Yusra AlSayyad for helping me debug the final portion of this. 15 PRs merged, and we're finally done!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Christopher Waters, Jim Bosch, John Parejko, Krzysztof Findeisen, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.