Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27174

Create InstrumentLabel class for ExposureInfo

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      AP F20-6 (November), AP S21-2 (January)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Following RFC-730, create an InstrumentLabel class analogous to FilterLabel and add it to ExposureInfo. Because this class, unlike FilterLabel, has no backwards-compatibility concerns, the two steps are combined into one ticket.

      Tests should include component support on obs_base, though this should be trivial since InstrumentLabel is a Persistable.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27175 Add InstrumentLabel to new exposures

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-730 Replace afw.image.Filter with simple label-based classes

          • Implemented
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-28506 Reading coadds fails on VisitInfo

          • Done

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Tim Jenness: that work is on DM-27175.

            Show
            Parejkoj John Parejko added a comment - Tim Jenness : that work is on DM-27175 .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Ok. I don't understand what that 3SP work is on DM-27175 but to propagate the instrument label to all products it's a one line patch to https://github.com/lsst/obs_base/blob/master/python/lsst/obs/base/makeRawVisitInfoViaObsInfo.py#L106 when you get to it.

            Show
            tjenness Tim Jenness added a comment - Ok. I don't understand what that 3SP work is on DM-27175 but to propagate the instrument label to all products it's a one line patch to https://github.com/lsst/obs_base/blob/master/python/lsst/obs/base/makeRawVisitInfoViaObsInfo.py#L106 when you get to it.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Looks good; minor comments only.

            Show
            krzys Krzysztof Findeisen added a comment - Looks good; minor comments only.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Post-review jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33404/pipeline

            Show
            Parejkoj John Parejko added a comment - Post-review jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33404/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the quick review: I responded to and cleaned up based on your comments. Jenkins is clean.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for the quick review: I responded to and cleaned up based on your comments. Jenkins is clean. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              John Parejko, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.