Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27177

Remove lsst.afw.image.Filter

    XMLWordPrintable

    Details

      Description

      Remove wavelength information and the defineFilters method from obs.base.FilterDefinition (this requires changes to all obs packages). Once this is done, remove the Filter class and its supporting infrastructure. These two actions should be done on the same ticket because removing defineFilters potentially invalidates any remaining use of Filter.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31706 Do Release 24.0.0 of Science Pipelines

          • In Progress

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27811 Remove "filterLabel" transitional API

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27170 Deprecate and phase out afw::image::Filter

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28088 Change fgcmcal to use FilterLabel

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28093 Change isrTask (and relevant configs) to use physicalLabel

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28334 makeTransmissionCurves needs to be updated to use physical filter names

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28166 Update obs package use of filter.getId() in _computeCoaddExposureId

          • Won't Fix
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-730 Replace afw.image.Filter with simple label-based classes

          • Implemented
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-748 Accelerated deprecation of Filter

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Following discussion on #dm-naming-things, we want the final API to be Exposure::getFilter(), ExposureFitsReader::readFilter(), and butler.get(exposure.filter). Once Filter is removed, these names are available for immediate(?) reuse, along with deprecation of getFilterLabel() and .filterLabel.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Following discussion on #dm-naming-things , we want the final API to be Exposure::getFilter() , ExposureFitsReader::readFilter() , and butler.get(exposure.filter) . Once Filter is removed, these names are available for immediate(?) reuse, along with deprecation of getFilterLabel() and .filterLabel .
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            I'm claiming this for June, since I just realized that we're finally unblocked on this with the merging of DM-28334 in March. Not sure if we can get it in before the version 24 fork...

            Show
            krzys Krzysztof Findeisen added a comment - I'm claiming this for June, since I just realized that we're finally unblocked on this with the merging of DM-28334 in March. Not sure if we can get it in before the version 24 fork...
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            Thanks for agreeing to look at this, Jim Bosch! This issue both removes all the old Filter structure and replaces it with new getFilter methods (per the above comments). In addition to the final Jenkins check, I verified that Science Pipelines didn't break when all the old code was removed, but the new methods/components had not yet been added.

            In addition to all the PRs linked from Jira, there's also ap_pipe#112. The most substantial changes are in afw#639 and obs_base#422.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Thanks for agreeing to look at this, Jim Bosch ! This issue both removes all the old Filter structure and replaces it with new getFilter methods (per the above comments). In addition to the final Jenkins check, I verified that Science Pipelines didn't break when all the old code was removed, but the new methods/components had not yet been added. In addition to all the PRs linked from Jira, there's also ap_pipe#112 . The most substantial changes are in afw#639 and obs_base#422 .
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Reviewed!  Only comment is in afw; one code comment that got changed to getFilterLabel and then didn't get chanced back that I could see.

            Thanks for the attention to detail and the git-commit precision and consistency; that made this very easy to review.

            Show
            jbosch Jim Bosch added a comment - Reviewed!  Only comment is in afw; one code comment that got changed to getFilterLabel and then didn't get chanced back that I could see. Thanks for the attention to detail and the git-commit precision and consistency; that made this very easy to review.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Jim Bosch
              Watchers:
              Eric Bellm, Ian Sullivan, Jim Bosch, John Parejko, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.