Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27180

NaNs in measurePhotonTransferCurve.py causing failures

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe
    • Labels:
      None

      Description

      When running the PTC analysis on BOT run 12606, many amps failed to return valid PTC curves.  I traced this to saturated images in the flat pairs, which caused NaNs in the mean/variance values.  When the code runs the _getInitialGoodPoints routine, the medianRatio parameter becomes NaN, and then all points fail.  I was able to fix this by changing the medianRatio from np.median to np.nanmedian, and then the PTC curves ran OK, but then the plotPtc.py routine failed to plot the PTCs.  As a workaround, I just eliminated the saturated flat pairs from the input deck, but long term the code needs to be robust to saturated inputs.  FWIW, I swear that this problem was not there a few weeks ago.

        Attachments

          Issue Links

            Activity

            cslage Craig Lage created issue -
            czw Christopher Waters made changes -
            Field Original Value New Value
            Link This issue blocks DM-27161 [ DM-27161 ]
            plazas Andrés Alejandro Plazas Malagón made changes -
            Assignee Andrés Alejandro Plazas Malagón [ plazas ]
            plazas Andrés Alejandro Plazas Malagón made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            plazas Andrés Alejandro Plazas Malagón made changes -
            Attachment PTC_det36.pdf [ 45798 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Reviewers Merlin Fisher-Levine [ mfisherlevine ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            mfisherlevine Merlin Fisher-Levine made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            czw Christopher Waters made changes -
            Epic Link DM-26805 [ 439757 ]
            czw Christopher Waters made changes -
            Team Data Release Production [ 10301 ]
            plazas Andrés Alejandro Plazas Malagón made changes -
            Story Points 3
            plazas Andrés Alejandro Plazas Malagón made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            czw Christopher Waters made changes -
            Remote Link This issue links to "Page (Confluence)" [ 26324 ]

              People

              Assignee:
              plazas Andrés Alejandro Plazas Malagón
              Reporter:
              cslage Craig Lage
              Reviewers:
              Merlin Fisher-Levine
              Watchers:
              Andrés Alejandro Plazas Malagón, Christopher Waters, Craig Lage, Merlin Fisher-Levine
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: