Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27184

Fixed bugs in using the JSON-based configuration store by applications in package partition

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      Fix a bug introduced in DM-26754. The code makes incorrect assumptions in handling command line parameters of the string type as boolean flags. As a result of this the following problem is reported:

      % sph-partition \
          -c  test_config.json \
          --in.path  cccccc.csv \
          --out.dir   /project/hchiang2/ \
          -v
      ConfigStore::Value<T>::convert: incorrect type conversion for parameter: 'verbose', details: [json.exception.type_error.302] type must be boolean, but is string
      

        Attachments

          Issue Links

            Activity

            Hide
            npease Nate Pease added a comment -

            Igor Gaponenko I've looked at changes, I think Kian-Tat Lim has raised a point that ought to at least be discussed, if not fixed.

            Show
            npease Nate Pease added a comment - Igor Gaponenko I've looked at changes, I think Kian-Tat Lim has raised a point that ought to at least be discussed, if not fixed.
            Hide
            npease Nate Pease added a comment -

            looks good

            Show
            npease Nate Pease added a comment - looks good

              People

              Assignee:
              gapon Igor Gaponenko
              Reporter:
              gapon Igor Gaponenko
              Reviewers:
              Nate Pease
              Watchers:
              Fritz Mueller, Hsin-Fang Chiang, Igor Gaponenko, Nate Pease
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: