Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27319

Examine behavior of IsrTask wrt doSaturation and doSaturationInterpolation

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Team:
      Data Release Production

      Attachments

        Issue Links

        relates to

        Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19382 Refactor and reorder ISR steps to support writing pre-interpolated pixels

        • Done

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          czw Christopher Waters added a comment -

          The attached image shows the results of six tests.  From left to right they are:

          1. Default processing with the master version of ip_isr (342f2d5f93437f75dc9248e99274bfb9)
            1. doSaturation=True
            2. doSaturationInterpolation=True
            3. doInterpolate=True
          2. Master ip_isr, no saturation (37c713f230eee5d3dfb9c47cbad73aa7)
            1. doSaturation=False
            2. doSaturationInterpolation=True
            3. doInterpolate=True
          3. Master ip_isr, no saturation, no saturation interpolation (37c713f230eee5d3dfb9c47cbad73aa7)
            1. doSaturation=False
            2. doSaturationInterpolation=False
            3. doInterpolate=True
          4. Master ip_isr, everything disabled (0ec56677c4f55e33b24db4f2eb7c0f8f)
            1. doSaturation=False
            2. doSaturationInterpolation=False
            3. doInterpolate=False
          5. Master ip_isr, only saturation interpolation disabled (342f2d5f93437f75dc9248e99274bfb9)
            1. doSaturation=True
            2. doSaturationInterpolation=False
            3. doInterpolate=True
          6. DM-27319 ticket of ip_isr, onlyl saturation interpolation disabled (37c713f230eee5d3dfb9c47cbad73aa7)
            1. doSaturation=True
            2. doSaturationInterpolation=False
            3. doInterpolate=True

          I think this shows that the ticket branch does the expected thing now, disabling doSaturationInterpolation prevents that mask from being interpolated, even if the pixels are masked as saturated.

          Show
          czw Christopher Waters added a comment - The attached image shows the results of six tests.  From left to right they are: Default processing with the master version of ip_isr (342f2d5f93437f75dc9248e99274bfb9) doSaturation=True doSaturationInterpolation=True doInterpolate=True Master ip_isr, no saturation (37c713f230eee5d3dfb9c47cbad73aa7) doSaturation=False doSaturationInterpolation=True doInterpolate=True Master ip_isr, no saturation, no saturation interpolation (37c713f230eee5d3dfb9c47cbad73aa7) doSaturation=False doSaturationInterpolation=False doInterpolate=True Master ip_isr, everything disabled (0ec56677c4f55e33b24db4f2eb7c0f8f) doSaturation=False doSaturationInterpolation=False doInterpolate=False Master ip_isr, only saturation interpolation disabled (342f2d5f93437f75dc9248e99274bfb9) doSaturation=True doSaturationInterpolation=False doInterpolate=True DM-27319 ticket of ip_isr, onlyl saturation interpolation disabled (37c713f230eee5d3dfb9c47cbad73aa7) doSaturation=True doSaturationInterpolation=False doInterpolate=True I think this shows that the ticket branch does the expected thing now, disabling doSaturationInterpolation prevents that mask from being interpolated, even if the pixels are masked as saturated.
          Hide
          Permalink
          mfisherlevine Merlin Fisher-Levine added a comment -

          Really nice presentation of the way the behaviour was and how it changes, thank you!

          Show
          mfisherlevine Merlin Fisher-Levine added a comment - Really nice presentation of the way the behaviour was and how it changes, thank you!

            People

            Assignee:
            czw Christopher Waters
            Reporter:
            czw Christopher Waters
            Reviewers:
            Merlin Fisher-Levine
            Watchers:
            Christopher Waters, Merlin Fisher-Levine
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.