Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2737

Build a DiscreteSkyMap that covers a collection of input exposures

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-S15-3
    • Team:
      Data Release Production

      Description

      This is essentially a rehash of the old trac Ticket #2702, originally reported by Jim Bosch, which reads:

      "I'd like to add a Task and bin script to create a DiscreteSkyMap that bounds a set of calexps specified by their data IDs. This makeDiscreteSkyMap.py could be used instead of makeSkyMap.py when the user would rather compute the pointing and size of the skymap from the input data than decide it manually."

      The work was done by Jim Bosch & Paul Price and exists on branch u/price/2702 in pipe_tasks, but it was never merged to master. I plan to simply rebase the commits in that branch onto master.

        Attachments

          Issue Links

            Activity

            Hide
            lauren Lauren MacArthur added a comment -

            The rebase includes the following commits, which can all be found on branch
            u/lauren/DM-2737:

            :~/LSST/pipe_tasks[u/lauren/DM-2737] $ git --no-pager log --stat --oneline --reverse origin/master..
            57f0012 Add task, bin script to build a DiscreteSkyMap from the bounds of a set of calexps (#2702).
             bin/makeDiscreteSkyMap.py                    |  25 +++++++++++++++++
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 154 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
             2 files changed, 179 insertions(+)
            810f970 Update to TaskRunner changes in pipe_base.
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 1 -
             1 file changed, 1 deletion(-)
            9bf189f Improvements to makeDiscreteSkyMap
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 15 +++++++++++----
             1 file changed, 11 insertions(+), 4 deletions(-)
            b7171ee Stop make[Discrete]SkyMap from saving/checking configs.
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 7 +++++++
             python/lsst/pipe/tasks/makeSkyMap.py         | 7 +++++++
             2 files changed, 14 insertions(+)
            f417c67 Add support for appending new tracts to makeDiscreteSkyMap.
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 28 ++++++++++++++++++++++------
             1 file changed, 22 insertions(+), 6 deletions(-)
            79ad62a MakeDiscreteSkyMap: ignore calexps that don't exist
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 3 +++
             1 file changed, 3 insertions(+)
            d6d6aaf makeDiscreteSkyMap: catch case where there is no data
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 3 ++-
             1 file changed, 2 insertions(+), 1 deletion(-)
            948feb2 adapt to #2860
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 2 +-
             python/lsst/pipe/tasks/makeSkyMap.py         | 2 +-
             2 files changed, 2 insertions(+), 2 deletions(-)
            1df8e6f Remove whitespace, fix copyright year, and minor formatting
             python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 23 +++++++++++------------
             python/lsst/pipe/tasks/makeSkyMap.py         | 28 ++++++++++++++--------------
             2 files changed, 25 insertions(+), 26 deletions(-)

            I tried running the makeDiscreteSkyMap.py command line task:

             makeDiscreteSkyMap.py /tigress/HSC/HSC/rerun/hsc-1193/20150410 --calib=/tigress/HSC/HSC/CALIB/ --output=/tigress/HSC/HSC/rerun/lauren/DM-1907/hsc-1193/20150410/ --id visit=1240^1238^1230 ccd=58^59^66^67^74^75
            : Loading config overrride file '/tigress/HSC/users/lauren/LSST/obs_subaru/config/makeDiscreteSkyMap.py'
            : Loading config overrride file '/tigress/HSC/users/lauren/LSST/obs_subaru/config/hsc/makeDiscreteSkyMap.py'
            : input=/tigress/HSC/HSC/rerun/hsc-1193/20150410
            : calib=/tigress/HSC/HSC/CALIB
            : output=/tigress/HSC/HSC/rerun/lauren/DM-1907/hsc-1193/20150410
            CameraMapper: Loading registry registry from /tigress/HSC/HSC/rerun/lauren/DM-1907/hsc-1193/20150410/_parent/_parent/registry.sqlite3
            CameraMapper: Loading calibRegistry registry from /tigress/HSC/HSC/CALIB/calibRegistry.sqlite3
            makeDiscreteSkyMap: Extracting bounding boxes of 18 images
            makeDiscreteSkyMap: Computing spherical convex hull
            makeDiscreteSkyMap: tract 0 has corners (150.287, 2.026), (149.540, 2.026), (149.540, 2.773), (150.288, 2.773) (RA, Dec deg) and 4 x 4 patches

            which, I believe indicates a successful run.

            For completeness, I ran a Buildbot which was successful.

            Show
            lauren Lauren MacArthur added a comment - The rebase includes the following commits, which can all be found on branch u/lauren/ DM-2737 : :~/LSST/pipe_tasks[u/lauren/DM-2737] $ git --no-pager log --stat --oneline --reverse origin/master.. 57f0012 Add task, bin script to build a DiscreteSkyMap from the bounds of a set of calexps (#2702). bin/makeDiscreteSkyMap.py | 25 +++++++++++++++++ python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 154 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 179 insertions(+) 810f970 Update to TaskRunner changes in pipe_base. python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 1 - 1 file changed, 1 deletion(-) 9bf189f Improvements to makeDiscreteSkyMap python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) b7171ee Stop make[Discrete]SkyMap from saving/checking configs. python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 7 +++++++ python/lsst/pipe/tasks/makeSkyMap.py | 7 +++++++ 2 files changed, 14 insertions(+) f417c67 Add support for appending new tracts to makeDiscreteSkyMap. python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) 79ad62a MakeDiscreteSkyMap: ignore calexps that don't exist python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 3 +++ 1 file changed, 3 insertions(+) d6d6aaf makeDiscreteSkyMap: catch case where there is no data python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) 948feb2 adapt to #2860 python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 2 +- python/lsst/pipe/tasks/makeSkyMap.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) 1df8e6f Remove whitespace, fix copyright year, and minor formatting python/lsst/pipe/tasks/makeDiscreteSkyMap.py | 23 +++++++++++------------ python/lsst/pipe/tasks/makeSkyMap.py | 28 ++++++++++++++-------------- 2 files changed, 25 insertions(+), 26 deletions(-) I tried running the makeDiscreteSkyMap.py command line task: makeDiscreteSkyMap.py /tigress/HSC/HSC/rerun/hsc-1193/20150410 --calib=/tigress/HSC/HSC/CALIB/ --output=/tigress/HSC/HSC/rerun/lauren/DM-1907/hsc-1193/20150410/ --id visit=1240^1238^1230 ccd=58^59^66^67^74^75 : Loading config overrride file '/tigress/HSC/users/lauren/LSST/obs_subaru/config/makeDiscreteSkyMap.py' : Loading config overrride file '/tigress/HSC/users/lauren/LSST/obs_subaru/config/hsc/makeDiscreteSkyMap.py' : input=/tigress/HSC/HSC/rerun/hsc-1193/20150410 : calib=/tigress/HSC/HSC/CALIB : output=/tigress/HSC/HSC/rerun/lauren/DM-1907/hsc-1193/20150410 CameraMapper: Loading registry registry from /tigress/HSC/HSC/rerun/lauren/DM-1907/hsc-1193/20150410/_parent/_parent/registry.sqlite3 CameraMapper: Loading calibRegistry registry from /tigress/HSC/HSC/CALIB/calibRegistry.sqlite3 makeDiscreteSkyMap: Extracting bounding boxes of 18 images makeDiscreteSkyMap: Computing spherical convex hull makeDiscreteSkyMap: tract 0 has corners (150.287, 2.026), (149.540, 2.026), (149.540, 2.773), (150.288, 2.773) (RA, Dec deg) and 4 x 4 patches which, I believe indicates a successful run. For completeness, I ran a Buildbot which was successful.
            Hide
            lauren Lauren MacArthur added a comment -

            Jim Bosch Would you mind reviewing this?

            Show
            lauren Lauren MacArthur added a comment - Jim Bosch Would you mind reviewing this?
            Hide
            jbosch Jim Bosch added a comment -

            Jim Bosch Would you mind reviewing this?

            Sure. If it's ready to go, just put it into the In Review state.

            Show
            jbosch Jim Bosch added a comment - Jim Bosch Would you mind reviewing this? Sure. If it's ready to go, just put it into the In Review state.
            Hide
            jbosch Jim Bosch added a comment -

            Only comment is a typo (which was probably mine originally): missing "of" in "set calexps" in docstring for MakeDiscreteSkyMapTask.

            Show
            jbosch Jim Bosch added a comment - Only comment is a typo (which was probably mine originally): missing "of" in "set calexps" in docstring for MakeDiscreteSkyMapTask .

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Lauren MacArthur, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: