Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27414

Update ts_rotator and ts_hexapod for renamed XML

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Nov 9 - Nov 23
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Update ts_rotator and ts_hexapod to accommodate renamed XML: Rotator -> MTRotator and Hexapod -> MTHexapod

      Also rename the packages to ts_MTRotator and ts_MTHexapod (though the final rename on github should probably be done after merging the other changes).

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27601 Release ts_salobj 6.1 and packages that must be updated for it.

          • Done
          is parent task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27520 Rename Rotator to MTRotator in ts_xml

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27415 Rename Hexapod to MTHexapod in ts_xml and rename the CSC package

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. CAP-646 RENAME Rotator to MTRotator

          • Undefined - No priority assigned (may not apply or be unknown)
          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            On 11 November this ticket was discussed in parking lot of the TSSW daily standup and it was decided to reassign it to Wouter van Reeven since Russell Owen is on holidays this week and we'd like to have this done this week.

            Show
            wvreeven Wouter van Reeven added a comment - On 11 November this ticket was discussed in parking lot of the TSSW daily standup and it was decided to reassign it to Wouter van Reeven since Russell Owen is on holidays this week and we'd like to have this done this week.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            As per request by Russell Owen I am also renaming the Telemetry topic MTRotator_Application to MTRotator_application.

            Show
            wvreeven Wouter van Reeven added a comment - As per request by Russell Owen I am also renaming the Telemetry topic MTRotator_Application to MTRotator_application.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            Doing the full rename proved to be beyond me so I am only doing ts_xml.

            Show
            wvreeven Wouter van Reeven added a comment - Doing the full rename proved to be beyond me so I am only doing ts_xml.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Merging is blocked until I release ts_salobj 6.1 and some associated packages (including ts_hexrotcomm, ts_hexapod and ts_rotator). See DM-27601 for details.

            I renamed ts_hexapod to ts_mthexapod and ts_rotator to ts_mtrotator. Tiago Ribeiro requested use of lowercase and I prefer it myself, though it does make the names look a bit strange. I have not yet renamed the repositories, because I need to finish DM-27601 first. But I have renamed the namespaces, e.g. lsst.ts.hexapod is now lsst.ts.mthexapod, and the conda packages, e.g. ts-hexapod is now ts-mthexapod.

            At this point DM-27601 is merged so I just renamed the github repos to match.

            To avoid confusion between the MTHexapod and MTRotator ts_idl enum modules and the CSC package names I modified ts_hexrotcomm, ts_hexapod, and ts_rotator to import the enum classes from these modules, e.g. from lsst.ts.idl.enums.MTHexapod import ControllerState. This change turned out to be unnecessary. Originally I thought I was going to rename the packages and namespaces with CamelCase, e.g. ts_MTHexapod, and that would have made this change far more important. I still think this change is an improvement, but am not entirely happy with it. Feel free to push back. It would be easy to undo.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited Merging is blocked until I release ts_salobj 6.1 and some associated packages (including ts_hexrotcomm, ts_hexapod and ts_rotator). See DM-27601 for details. I renamed ts_hexapod to ts_mthexapod and ts_rotator to ts_mtrotator. Tiago Ribeiro requested use of lowercase and I prefer it myself, though it does make the names look a bit strange. I have not yet renamed the repositories, because I need to finish DM-27601 first. But I have renamed the namespaces, e.g. lsst.ts.hexapod is now lsst.ts.mthexapod , and the conda packages, e.g. ts-hexapod is now ts-mthexapod . At this point DM-27601 is merged so I just renamed the github repos to match. To avoid confusion between the MTHexapod and MTRotator ts_idl enum modules and the CSC package names I modified ts_hexrotcomm, ts_hexapod, and ts_rotator to import the enum classes from these modules, e.g. from lsst.ts.idl.enums.MTHexapod import ControllerState . This change turned out to be unnecessary. Originally I thought I was going to rename the packages and namespaces with CamelCase, e.g. ts_MTHexapod, and that would have made this change far more important. I still think this change is an improvement, but am not entirely happy with it. Feel free to push back. It would be easy to undo. Pull requests: https://github.com/lsst-ts/ts_idl/pull/48 https://github.com/lsst-ts/ts_config_mttcs/pull/10 https://github.com/lsst-ts/ts_hexrotcomm/pull/25 https://github.com/lsst-ts/ts_mthexapod/pull/29 https://github.com/lsst-ts/ts_mtrotator/pull/26
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            I found several minor points to improve and one major one (in ts_mtrotator) but otherwise the changes look really good to me.

            Show
            wvreeven Wouter van Reeven added a comment - I found several minor points to improve and one major one (in ts_mtrotator) but otherwise the changes look really good to me.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Thank you for a great review. I made all the suggested fixes and released:

            • ts_config_mttcs v0.6.0
            • ts_idl v2.2.0
            • ts_hexrotcomm v0.11.0
            • ts_mthexapod v0.10.0
            • ts_mtrotator v0.9.0
            Show
            rowen Russell Owen added a comment - Thank you for a great review. I made all the suggested fixes and released: ts_config_mttcs v0.6.0 ts_idl v2.2.0 ts_hexrotcomm v0.11.0 ts_mthexapod v0.10.0 ts_mtrotator v0.9.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.