Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27445

Update the M2 SAL Interface Based on the Latest XML File in Phase 3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      TSSW Sprint - Nov 9 - Nov 23, TSSW Sprint - Nov 23 - Dec 07
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Update the M2 SAL interface based on the latest xml file. After the summit test at Feb. in this year, the M2 xml has been updated to support more use cases than before. This task is to update the software to support this.

      The main focus is in this task is the state machine transition and figure out how to let the M2 to be controllable by SAL.

      This task is in the phase 3.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27291 Update the M2 SAL Interface Based on the Latest XML File in Phase 2

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27761 Update the M2 SAL Interface Based on the Latest XML File in Phase 4

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27762 Fix the Problem of Built M2 Executable

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Supported the SAL heartbeat event. Added a parameter (sal_heartbeat) in parameter.json file for the debug use. Remove the Alive indicator in m2ms_incomingSAL.vi, which is replaced with the heartbeat.

            Supported the SAL settingVersions event. It looks like there is the restriction of string length. The following is what I got by the sacpp_MTM2_settingVersions_log:

            (base) [ttsai@ttsaidesktop src]$ ./sacpp_MTM2_settingVersions_log
            		 
            createReader : 0x1051ec8 , MTM2::logevent_settingVersions_abdade15 , MTM2_logevent_settingVersions_abdade15
            		 
            === Event settingVersions logger ready = 
            === Event settingVersions received = 
                recommendedSettingsVersion : default.csv
            		 
                recommendedSettingsLabels : Configurable_File_Description_20180831T091922_M2_optical.csv, Configurable_File_Description_20180831T092326_M2_handling.csv, Co
            		 
                settingsUrl : https://github.com/lsst-ts/ts_mtm2/tree/master/config/sysconfig
            		 
                priority : 0

            There is the truncation of recommendedSettingsLabels field.

            Supported the SAL settingsApplied event. Added the controller_waitTimeInMs in parameter.json to make sure the controller's processes have the enough time to finish the launch.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Supported the SAL heartbeat event. Added a parameter ( sal_heartbeat ) in parameter.json  file for the debug use. Remove the Alive indicator in m2ms_incomingSAL.vi , which is replaced with the heartbeat. Supported the SAL  settingVersions  event. It looks like there is the restriction of string length. The following is what I got by the sacpp_MTM2_settingVersions_log : (base) [ttsai @ttsaidesktop src]$ ./sacpp_MTM2_settingVersions_log createReader : 0x1051ec8 , MTM2::logevent_settingVersions_abdade15 , MTM2_logevent_settingVersions_abdade15 === Event settingVersions logger ready = === Event settingVersions received = recommendedSettingsVersion : default .csv recommendedSettingsLabels : Configurable_File_Description_20180831T091922_M2_optical.csv, Configurable_File_Description_20180831T092326_M2_handling.csv, Co settingsUrl : https: //github.com/lsst-ts/ts_mtm2/tree/master/config/sysconfig priority : 0 There is the truncation of recommendedSettingsLabels field. Supported the SAL settingsApplied event. Added the controller_waitTimeInMs in parameter.json to make sure the controller's processes have the enough time to finish the launch.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Supported the SAL commandableByDDS event. Rewrite the logic to send the settingVersions by letting the Model class to issue the user event of SAL Telemetry.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Supported the SAL  commandableByDDS  event. Rewrite the logic to send the settingVersions by letting the Model class to issue the user event of SAL Telemetry .
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Supported the SAL softwareVersions event and added the related configuration file (softwareVersions.json).

            Add the label in Jenkinsfile.labview to run the job at master node (linux environment) of CTIO Jenkins.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Supported the SAL  softwareVersions  event and added the related configuration file ( softwareVersions.json ). Add the label in Jenkinsfile.labview to run the job at master node (linux environment) of CTIO Jenkins.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Supported the build of executable. It is just a place holder at this moment. It looks like the built executable can not run correctly. Should fix this in DM-27762.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Supported the build of executable. It is just a place holder at this moment. It looks like the built executable can not run correctly. Should fix this in DM-27762 .
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PR:
            https://github.com/lsst-ts/ts_mtm2/pull/25

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PR: https://github.com/lsst-ts/ts_mtm2/pull/25 Thanks!
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Put this ticket to reviewed because Dave had approved the PR.

            Show
            ttsai Te-Wei Tsai added a comment - Put this ticket to reviewed because Dave had approved the PR.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Dave Mills
              Watchers:
              Dave Mills, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.