Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27696

Fix Boost deprecation warning in afw

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      AP S21-3 (February)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Building afw with GCC emits the following warning:

      In file included from tests/statisticsSpeed.cc:37:0:
      		 
      /software/lsstsw/stack_20200922/conda/miniconda3-py37_4.8.2/envs/lsst-scipipe/include/boost/timer.hpp:21:70: note: #pragma message: This header is deprecated. Use the facilities in <boost/timer/timer.hpp> instead.
      		 
       BOOST_HEADER_DEPRECATED( "the facilities in <boost/timer/timer.hpp>" )

      These changes involve moving from an outdated API to a newer one. The code changes are straightforward (see attached branch), but I get linker errors for all new methods (Boost Timer is a compiled library). I'm therefore creating a separate ticket for investigating this.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27169 Use FilterLabel in Exposure/ExposureInfo

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24331 Fix ImageDifferenceTask and related v21 deprecation warnings

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            It looks like the Boost libraries to be linked against are defined in https://github.com/lsst/sconsUtils/tree/master/configs; i.e. they will become available for any C++ project, not just afw. That makes this more than just a trivial API migration.

            Show
            krzys Krzysztof Findeisen added a comment - It looks like the Boost libraries to be linked against are defined in https://github.com/lsst/sconsUtils/tree/master/configs ; i.e. they will become available for any C++ project, not just afw . That makes this more than just a trivial API migration.
            Hide
            Permalink
            bvan Brian Van Klaveren added a comment -

            looks good, from the github conversation, boost timer is only used, and likely to only be used, during unit testing, and it was added as such.

            Show
            bvan Brian Van Klaveren added a comment - looks good, from the github conversation, boost timer is only used, and likely to only be used, during unit testing, and it was added as such.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Sorry, did you also look at afw#569? It seems to have been missed by Jira.

            Show
            krzys Krzysztof Findeisen added a comment - Sorry, did you also look at afw#569 ? It seems to have been missed by Jira.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Brian Van Klaveren
              Watchers:
              Brian Van Klaveren, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.