Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2636 Update code to use the function provided in DM-2635
  3. DM-2772

datarel tests depend on EUPS

    XMLWordPrintable

    Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: datarel
    • Labels:
      None
    • Team:
      SQuaRE

      Description

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2768 investigate decomposition of stack build into independent packages

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-44 Remove build system dependencies from tests

          • Implemented
          relates to

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-57 retire datarel, ap, and testing_endToEnd packages

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            jhoblitt Joshua Hoblitt created issue -
            jhoblitt Joshua Hoblitt made changes -
            Field Original Value New Value
            Link This issue blocks RFC-44 [ RFC-44 ]
            jhoblitt Joshua Hoblitt made changes -
            Link This issue blocks DM-2768 [ DM-2768 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            pylint indicates that the eups import here is boilerplate that is not used. I think that is true for a lot of the eups imports.

            Show
            tjenness Tim Jenness added a comment - pylint indicates that the eups import here is boilerplate that is not used. I think that is true for a lot of the eups imports.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Joshua Hoblitt should feel free to remove any and all of the unused "import eups" lines in SConscript files or tests. Cases where eups.productDir() are used need to be replaced by the new function from RFC-44, of course.

            Show
            ktl Kian-Tat Lim added a comment - Joshua Hoblitt should feel free to remove any and all of the unused " import eups " lines in SConscript files or tests. Cases where eups.productDir() are used need to be replaced by the new function from RFC-44 , of course.
            frossie Frossie Economou made changes -
            Assignee Kian-Tat Lim [ ktl ] Frossie Economou [ frossie ]
            tjenness Tim Jenness made changes -
            Assignee Frossie Economou [ frossie ] Joshua Hoblitt [ jhoblitt ]
            jhoblitt Joshua Hoblitt made changes -
            Parent DM-2636 [ 17388 ]
            Issue Type Bug [ 1 ] Technical task [ 10002 ]
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            After some discussion in the office and on hipchat, we've decided to convert all the eups related tickets to be sub tasks of DM-2636 instead of closing them won't fix.

            Show
            jhoblitt Joshua Hoblitt added a comment - After some discussion in the office and on hipchat, we've decided to convert all the eups related tickets to be sub tasks of DM-2636 instead of closing them won't fix.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            I've converted the dataral tests in tickets/DM-2636 but I don't want to touch all of the os.environ calls in the various scripts under ./bin, which appear to be largely untested.

            Show
            jhoblitt Joshua Hoblitt added a comment - I've converted the dataral tests in tickets/ DM-2636 but I don't want to touch all of the os.environ calls in the various scripts under ./bin, which appear to be largely untested.
            jhoblitt Joshua Hoblitt made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to RFC-57 [ RFC-57 ]
            jhoblitt Joshua Hoblitt made changes -
            Resolution Done [ 10000 ]
            Status In Review [ 10004 ] Done [ 10002 ]
            frossie Frossie Economou made changes -
            Team SQuaRE [ 10302 ]

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              jhoblitt Joshua Hoblitt
              Reviewers:
              Tim Jenness
              Watchers:
              Frossie Economou, Joshua Hoblitt, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.