Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-277

datarel.utils.getPsf() fails

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: datarel
    • Labels:
      None
    • Team:
      Architecture

      Description

      87d8d5a modified utils.py to provide a function to get a PSF from an exposure. Unfortunately, while one typo ("imageOrgin" -> "imageOrigin") was fixed in the process, another one occurred ("dataId=dataId" was left out). This causes any attempt to retrieve a PSF using this function to fail for lack of required data identifier keys.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          ktl Kian-Tat Lim created issue -
          ktl Kian-Tat Lim made changes -
          Field Original Value New Value
          Watchers Kian-Tat Lim [ Kian-Tat Lim ] Kian-Tat Lim, Russell Owen [ Kian-Tat Lim, Russell Owen ]
          ktl Kian-Tat Lim made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          ktl Kian-Tat Lim made changes -
          Status In Progress [ 3 ] In Progress [ 3 ]
          ktl Kian-Tat Lim made changes -
          Status In Progress [ 3 ] Ready for Review [ 10003 ]
          ktl Kian-Tat Lim made changes -
          Assignee Kian-Tat Lim [ ktl ] Russell Owen [ rowen ]
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment - - edited

          Fix made in 3c0cc0a.

          Includes a pseudo-test case that finds this problem but does not actually retrieve a PSF.

          Show
          ktl Kian-Tat Lim added a comment - - edited Fix made in 3c0cc0a . Includes a pseudo-test case that finds this problem but does not actually retrieve a PSF.
          ktl Kian-Tat Lim made changes -
          Issue Type Story [ 10001 ] Bug [ 1 ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Oops. I also pushed a fix to bugfix/DM-277. Go ahead and use yours since it includes a unit test.

          Show
          rowen Russell Owen added a comment - Oops. I also pushed a fix to bugfix/ DM-277 . Go ahead and use yours since it includes a unit test.
          ktl Kian-Tat Lim made changes -
          Resolution Done [ 10000 ]
          Status Ready for Review [ 10003 ] Done [ 10002 ]
          ktl Kian-Tat Lim made changes -
          Assignee Russell Owen [ rowen ] Kian-Tat Lim [ ktl ]
          Hide
          Permalink
          ktl Kian-Tat Lim added a comment -

          Merged to master in 2b15721 and pushed.

          Show
          ktl Kian-Tat Lim added a comment - Merged to master in 2b15721 and pushed.
          tjenness Tim Jenness made changes -
          Team Architecture [ 10304 ]

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            ktl Kian-Tat Lim
            Watchers:
            Kian-Tat Lim, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.