Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27811

Remove "filterLabel" transitional API

    XMLWordPrintable

Details

    • 4
    • No

    Description

      To allow transition to FilterLabel without breaking existing, Filter-based code, DM-27169 introduced getFilterLabel() methods on Exposure and ExposureFitsReader as well as a .filterLabel component in the Butler. However, the preferred API uses getFilter() and .filter, which is freed up in DM-27177.

      Per current deprecation rules, all in-Stack migration back to filter as the API name should have been done on DM-27177; once nobody is using FilterLabel except as a class name, remove the transitional APIs.

      Attachments

        Issue Links

          Activity

            Assuming that DM-27177 gets into the upcoming release 24, the getFilterLabel methods cannot be removed until after release 25.

            krzys Krzysztof Findeisen added a comment - Assuming that DM-27177 gets into the upcoming release 24, the getFilterLabel methods cannot be removed until after release 25.

            My previous comment was wrong – per RFC-748, we're allowed to remove the transitional APIs after the release in which they are deprecated (set to be release 24).

            krzys Krzysztof Findeisen added a comment - My previous comment was wrong – per RFC-748 , we're allowed to remove the transitional APIs after the release in which they are deprecated (set to be release 24).
            erykoff Eli Rykoff added a comment - PRs: https://github.com/lsst/daf_butler/pull/740 https://github.com/lsst/obs_base/pull/434 https://github.com/lsst/afw/pull/660 Jenkins running here, will see if it finds anything that a github search didn't turn up: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37410/pipeline And thanks for all the handy TODO's!

            The obs_base PR still has filterLabel in exposureAssembler.py; since we're not actually using disassembled components anywhere, I don't think Jenkins will pick it up.

            krzys Krzysztof Findeisen added a comment - The obs_base PR still has filterLabel in exposureAssembler.py ; since we're not actually using disassembled components anywhere, I don't think Jenkins will pick it up.
            tjenness Tim Jenness added a comment -

            We always use disassembly in pipelines_check

            tjenness Tim Jenness added a comment - We always use disassembly in pipelines_check
            erykoff Eli Rykoff added a comment -

            Well, whatever tests may have tickled this code were removed by my surgery, and nothing in pipelines_check failed either. I've now removed the remaining calls in obs_base and have started a new jenkins. Thanks for catching that!

            erykoff Eli Rykoff added a comment - Well, whatever tests may have tickled this code were removed by my surgery, and nothing in pipelines_check failed either. I've now removed the remaining calls in obs_base and have started a new jenkins. Thanks for catching that!

            People

              erykoff Eli Rykoff
              krzys Krzysztof Findeisen
              Krzysztof Findeisen
              Eli Rykoff, John Parejko, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.