Fix Version/s: None
Component/s: afw, daf_butler, obs_base
To allow transition to FilterLabel without breaking existing, Filter-based code,
DM-27169 introduced getFilterLabel() methods on Exposure and ExposureFitsReader as well as a .filterLabel component in the Butler. However, the preferred API uses getFilter() and .filter, which is freed up in DM-27177.
Per current deprecation rules, all in-Stack migration back to filter as the API name should have been done on
DM-27177; once nobody is using FilterLabel except as a class name, remove the transitional APIs.
DM-32971 Do Release 25.0.0 of Science Pipelines
- In Progress
- is blocked by
DM-31706 Do Release 24.0.0 of Science Pipelines
- In Progress
DM-27177 Remove lsst.afw.image.Filter
- is triggered by
RFC-730 Replace afw.image.Filter with simple label-based classes
- relates to
DM-36507 Remove references to filterLabel component from cp_pipe
My previous comment was wrong – per
RFC-748, we're allowed to remove the transitional APIs after the release in which they are deprecated (set to be release 24).
Jenkins running here, will see if it finds anything that a github search didn't turn up:
And thanks for all the handy TODO's!
The obs_base PR still has filterLabel in exposureAssembler.py; since we're not actually using disassembled components anywhere, I don't think Jenkins will pick it up.
Well, whatever tests may have tickled this code were removed by my surgery, and nothing in pipelines_check failed either. I've now removed the remaining calls in obs_base and have started a new jenkins. Thanks for catching that!
DM-27177gets into the upcoming release 24, the getFilterLabel methods cannot be removed until after release 25.