Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27811

Remove "filterLabel" transitional API

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Urgent?:
      No

      Description

      To allow transition to FilterLabel without breaking existing, Filter-based code, DM-27169 introduced getFilterLabel() methods on Exposure and ExposureFitsReader as well as a .filterLabel component in the Butler. However, the preferred API uses getFilter() and .filter, which is freed up in DM-27177.

      Per current deprecation rules, all in-Stack migration back to filter as the API name should have been done on DM-27177; once nobody is using FilterLabel except as a class name, remove the transitional APIs.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32971 Do Release 25.0.0 of Science Pipelines

          • In Progress
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27177 Remove lsst.afw.image.Filter

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31706 Do Release 24.0.0 of Science Pipelines

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-730 Replace afw.image.Filter with simple label-based classes

          • Implemented
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-36507 Remove references to filterLabel component from cp_pipe

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            krzys Krzysztof Findeisen created issue -
            krzys Krzysztof Findeisen made changes -
            Field Original Value New Value
            Link This issue is blocked by DM-27177 [ DM-27177 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue is triggered by RFC-730 [ RFC-730 ]
            krzys Krzysztof Findeisen made changes -
            Summary Remove "filterLabel" API Remove "filterLabel" transitional API
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Assuming that DM-27177 gets into the upcoming release 24, the getFilterLabel methods cannot be removed until after release 25.

            Show
            krzys Krzysztof Findeisen added a comment - Assuming that DM-27177 gets into the upcoming release 24, the getFilterLabel methods cannot be removed until after release 25.
            krzys Krzysztof Findeisen made changes -
            Link This issue is blocked by DM-32971 [ DM-32971 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            My previous comment was wrong – per RFC-748, we're allowed to remove the transitional APIs after the release in which they are deprecated (set to be release 24).

            Show
            krzys Krzysztof Findeisen added a comment - My previous comment was wrong – per RFC-748 , we're allowed to remove the transitional APIs after the release in which they are deprecated (set to be release 24).
            krzys Krzysztof Findeisen made changes -
            Link This issue is blocked by DM-31706 [ DM-31706 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue is blocked by DM-32971 [ DM-32971 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue blocks DM-32971 [ DM-32971 ]
            krzys Krzysztof Findeisen made changes -
            Story Points 4 6
            krzys Krzysztof Findeisen made changes -
            Story Points 6 4
            erykoff Eli Rykoff made changes -
            Assignee Eli Rykoff [ erykoff ]
            erykoff Eli Rykoff made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            PRs:
            https://github.com/lsst/daf_butler/pull/740
            https://github.com/lsst/obs_base/pull/434
            https://github.com/lsst/afw/pull/660

            Jenkins running here, will see if it finds anything that a github search didn't turn up:
            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37410/pipeline

            And thanks for all the handy TODO's!

            Show
            erykoff Eli Rykoff added a comment - PRs: https://github.com/lsst/daf_butler/pull/740 https://github.com/lsst/obs_base/pull/434 https://github.com/lsst/afw/pull/660 Jenkins running here, will see if it finds anything that a github search didn't turn up: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37410/pipeline And thanks for all the handy TODO's!
            erykoff Eli Rykoff made changes -
            Reviewers Krzysztof Findeisen [ krzys ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            The obs_base PR still has filterLabel in exposureAssembler.py; since we're not actually using disassembled components anywhere, I don't think Jenkins will pick it up.

            Show
            krzys Krzysztof Findeisen added a comment - The obs_base PR still has filterLabel in exposureAssembler.py ; since we're not actually using disassembled components anywhere, I don't think Jenkins will pick it up.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            We always use disassembly in pipelines_check

            Show
            tjenness Tim Jenness added a comment - We always use disassembly in pipelines_check
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Well, whatever tests may have tickled this code were removed by my surgery, and nothing in pipelines_check failed either. I've now removed the remaining calls in obs_base and have started a new jenkins. Thanks for catching that!

            Show
            erykoff Eli Rykoff added a comment - Well, whatever tests may have tickled this code were removed by my surgery, and nothing in pipelines_check failed either. I've now removed the remaining calls in obs_base and have started a new jenkins. Thanks for catching that!
            krzys Krzysztof Findeisen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            erykoff Eli Rykoff made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            krzys Krzysztof Findeisen made changes -
            Link This issue relates to DM-36507 [ DM-36507 ]

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Eli Rykoff, John Parejko, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.