Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27843

add anyFilterMapsToThis support to ReferenceObjectLoader

    XMLWordPrintable

    Details

      Description

      The gen3 ReferenceObjectLoader needs to have support for the anyFilterMapsToThis config option that was added in DM-26007. This requires updating addFluxAliases in that method, but I don't know that there are any unittests for this class to check its behavior. It may have also diverged from the gen2 code in otherways.

        Attachments

          Issue Links

            Activity

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35621/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Thanks Jim Bosch for the review offer. There's a lot of copy/paste refactoring, and I'm not sure whether reviewing per-commit or all in one go would be better.

            Show
            Parejkoj John Parejko added a comment - Thanks Jim Bosch for the review offer. There's a lot of copy/paste refactoring, and I'm not sure whether reviewing per-commit or all in one go would be better.
            Hide
            jbosch Jim Bosch added a comment -

            Review complete. I think all of my comments are about docs, and many are actually preexisting (just moved around).

            Show
            jbosch Jim Bosch added a comment - Review complete. I think all of my comments are about docs, and many are actually preexisting (just moved around).
            Show
            Parejkoj John Parejko added a comment - Post review/rebase jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35626/pipeline

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, Meredith Rawls, Merlin Fisher-Levine, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.