Details
-
Type:
Story
-
Status: To Do
-
Resolution: Unresolved
-
Fix Version/s: None
-
Component/s: pex_config
-
Labels:
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
This ticket will look into issues with determining if configs can be compared equal. In DM-27784 we found there were lots of edge cases that made this difficult. Somewhere the id of the config objects was getting used which I suspect was a mistake.
When trying to use the toDict methods to compare for equality we ran into trouble where some of our configs may contain NaN on purpose, however NaN never equals anything including itself, so that caused config to break.
A more robust way to determine equality should be determined and implemented.
When this is done, the `_eq_` method on `TaskDef` in `pipe_base` should be updated to consider config equality.
Attachments
Issue Links
- relates to
-
- To Do
A related problem (I could swear I created an issue, but now I can't find it) is that equality of ConfigurableFields and RegistryFields is not well-behaved (IIRC they always compare unequal). Since nearly all task configs use one of these field types...