XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
1
• Team:
Data Release Production
• Urgent?:
No

#### Description

CpFlatNormalizationTask iterates through the detectors at line 297 with:

 if self.config.level == 'DETECTOR':  for detId, det in enumerate(detSet):   for amp in camera[detId]: 

This fails for decam with *** KeyError: 'Detector for key 0 not found.', because the detectors start at 1. This should probably refer to camera[det].

#### Activity

No builds found.
Colin Slater created issue -
Hide
John Parejko added a comment -

As noted on slack, this should just be for detector in camera:, no indexing should be necessary.

Show
John Parejko added a comment - As noted on slack, this should just be for detector in camera:, no indexing should be necessary.
Field Original Value New Value
Status To Do [ 10001 ] In Progress [ 3 ]
 Reviewers Meredith Rawls [ mrawls ] Status In Progress [ 3 ] In Review [ 10004 ]
Hide
Christopher Waters added a comment - - edited

The indexing is necessary to correctly find the "detector scale" that this block is repacking into a nested set of defaultdicts.

Show
Christopher Waters added a comment - - edited The indexing is necessary to correctly find the "detector scale" that this block is repacking into a nested set of defaultdicts. Link for reference:  https://lsstc.slack.com/archives/CQ4SMS3QQ/p1607023685058300
 Epic Link DM-26795 [ 439745 ]
 Story Points 1
Hide
Meredith Rawls added a comment -

Thanks for clarifying the indexing situation, this is quite a nested adventure. I do think some minor variable renaming would really enhance clarity (det > detector and exp > exposure throughout, for instance). If you're able to do that here, bonus points! But if not, the fix is good as is.

Show
Meredith Rawls added a comment - Thanks for clarifying the indexing situation, this is quite a nested adventure. I do think some minor variable renaming would really enhance clarity (det > detector and exp  > exposure throughout, for instance). If you're able to do that here, bonus points! But if not, the fix is good as is.
 Status In Review [ 10004 ] Reviewed [ 10101 ]
 Resolution Done [ 10000 ] Status Reviewed [ 10101 ] Done [ 10002 ]

#### People

Assignee:
Christopher Waters
Reporter:
Colin Slater
Reviewers:
Meredith Rawls
Watchers:
Christopher Waters, Colin Slater, John Parejko, Meredith Rawls