Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27887

fix rotator GUI telemetry plots

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      TSSW Sprint - Apr 12 - Apr 26, TSSW Sprint - Apr 26 - May 10
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The rotator operator's menu, figure 14, (attached below), shows the telemetry plots. 

      However, it is not clear what the range of the time axis is, and these large numbers are hard to read (most likely they are in unit of seconds)

      To make this useful, we need to 

      (1) look into the unit and range of the time axis, and label them clearly.

      (2) add a drop down menu, so that users can choose "past 2 minutes", "past 5 minutes" etc to easily reconfigure the range of the time axis. (exact menu items TBD)

        Attachments

          Issue Links

            Activity

            No builds found.
            bxin Bo Xin [X] (Inactive) created issue -
            bxin Bo Xin [X] (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-27619 [ 441883 ]
            ttsai Te-Wei Tsai made changes -
            Link This issue relates to DM-27886 [ DM-27886 ]
            ttsai Te-Wei Tsai made changes -
            Story Points 1
            Labels HexRot MainTelescope ccw-rotator-integration-test
            ttsai Te-Wei Tsai made changes -
            End date 14/Apr/21
            Sprint TSSW Sprint - Apr 12 - Apr 26 [ 1089 ]
            Start date 13/Apr/21
            ttsai Te-Wei Tsai made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            The plotting figure is using the waveform chart now and may not fulfill the description of ticket:
            1. What Is the Difference between Waveform Graphs and Waveform Charts in LabVIEW?
            2. Change Waveform Chart History Length in LabVIEW

            I am thinking to use the following link:
            1. Using the Waveform Data Type in LabVIEW
            2. Fixed size shift register
            3. Data Queue PtByPt VI

            Show
            ttsai Te-Wei Tsai added a comment - - edited The plotting figure is using the waveform chart now and may not fulfill the description of ticket: 1. What Is the Difference between Waveform Graphs and Waveform Charts in LabVIEW? 2. Change Waveform Chart History Length in LabVIEW I am thinking to use the following link: 1. Using the Waveform Data Type in LabVIEW 2. Fixed size shift register 3. Data Queue PtByPt VI
            wvreeven Wouter van Reeven made changes -
            Sprint TSSW Sprint - Apr 12 - Apr 26 [ 1089 ] TSSW Sprint - Apr 12 - Apr 26, TSSW Sprint - Apr 26 - May 10 [ 1089, 1091 ]
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            I realized the vi of telemetry details will only run one loop in the while loop (add the True value to the stop button). I needed to change this, otherwise, there might be the problem of memory leak.

            I removed the auto scale of x-axis, which looks like a problem.

            Show
            ttsai Te-Wei Tsai added a comment - - edited I realized the vi of telemetry details will only run one loop in the while loop (add the True value to the stop button). I needed to change this, otherwise, there might be the problem of memory leak. I removed the auto scale of x-axis, which looks like a problem.
            ttsai Te-Wei Tsai made changes -
            Story Points 1 2
            ttsai Te-Wei Tsai made changes -
            Attachment rotatorFigUpdate.png [ 49353 ]
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            Tested the updated figure with the fake 0 data:

            Show
            ttsai Te-Wei Tsai added a comment - - edited Tested the updated figure with the fake 0 data:
            Hide
            ttsai Te-Wei Tsai added a comment -
            Show
            ttsai Te-Wei Tsai added a comment - Please review the PR: https://github.com/lsst-ts/ts_rotator_gui/pull/8 Thanks!
            ttsai Te-Wei Tsai made changes -
            Reviewers Bo Xin [ bxin ] Bo Xin, Dave Mills [ bxin, dmills ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            bxin Bo Xin [X] (Inactive) added a comment -

            perfect !

            Show
            bxin Bo Xin [X] (Inactive) added a comment - perfect !
            bxin Bo Xin [X] (Inactive) made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            bxin Bo Xin [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            ttsai Te-Wei Tsai made changes -
            Link This issue is triggering SUMMIT-5163 [ SUMMIT-5163 ]

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              bxin Bo Xin [X] (Inactive)
              Reviewers:
              Bo Xin [X] (Inactive), Dave Mills
              Watchers:
              Bo Xin [X] (Inactive), Dave Mills, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.