Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-27919

DECam "physical_filter" is too long and has spaces

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      AP S21-3 (February)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      At present, the physical_filter for DECam is something like "g DECam SDSS c0001 4720.0 1520.0", which is not ideal. It should probably just be "g"? Or perhaps, e.g., "g_4720_1520" if more specificity is desired. (And so on for the other bands.)

      The goals here are (1) no spaces and (2) shorter as feasible.

      Ideally this can be fixed in the next few weeks, before any shared DECam gen3 repository lands in /datasets.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            That looks like it should work (I didn't see a pull request so can't comment on github). It would be good if you could add a test to test_templates.py – maybe as simple as turning the physical_filter in the example into "U 2" or something.

            Show
            tjenness Tim Jenness added a comment - That looks like it should work (I didn't see a pull request so can't comment on github). It would be good if you could add a test to test_templates.py – maybe as simple as turning the physical_filter in the example into "U 2" or something.
            Hide
            ktl Kian-Tat Lim added a comment -

            Nobody is ever going to have both "U 2" and "U_2" as physical filters, are they? (Of course, now that I say it, someone is going to do it...) We should document that this is banned.

            Show
            ktl Kian-Tat Lim added a comment - Nobody is ever going to have both "U 2" and "U_2" as physical filters, are they? (Of course, now that I say it, someone is going to do it...) We should document that this is banned.
            Hide
            tjenness Tim Jenness added a comment -

            I hope they don't. It's the balance between usability of data products and uniqueness of dimension space.

            Show
            tjenness Tim Jenness added a comment - I hope they don't. It's the balance between usability of data products and uniqueness of dimension space.
            Hide
            mrawls Meredith Rawls added a comment -

            Haha... I cannot imagine this reality, but that's how many weird breakages happen, isn't it. I'd be happy to document this is banned if someone tells me where to do so.

            Show
            mrawls Meredith Rawls added a comment - Haha... I cannot imagine this reality, but that's how many weird breakages happen, isn't it. I'd be happy to document this is banned if someone tells me where to do so.
            Show
            ktl Kian-Tat Lim added a comment - https://pipelines.lsst.io/modules/lsst.obs.base/creating-an-obs-package.html#filters ?

              People

              Assignee:
              mrawls Meredith Rawls
              Reporter:
              mrawls Meredith Rawls
              Reviewers:
              Tim Jenness
              Watchers:
              Colin Slater, Ian Sullivan, Jim Bosch, Kian-Tat Lim, Meredith Rawls, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.