Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2792

Make the new astrometry task the default task

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom, pipe_tasks
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-W16-1
    • Team:
      Alert Production

      Description

      The new astrometry task should be the default astrometry task, but we need to make sure it is good enough first.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment - - edited

          A trivial change. I'm hoping you can spare time for this as you are an expert on astrometry.

          Changes in pipe_tasks CalibrateTask in calibrate.py on branch tickets/DM-2792

          I plan to announce the change on dm-users after merging. If you feel more should be done, please let me know.

          Show
          rowen Russell Owen added a comment - - edited A trivial change. I'm hoping you can spare time for this as you are an expert on astrometry. Changes in pipe_tasks CalibrateTask in calibrate.py on branch tickets/ DM-2792 I plan to announce the change on dm-users after merging. If you feel more should be done, please let me know.
          Hide
          price Paul Price added a comment -

          Changes are fine.

          Please be sure to run CI before merging, as this certainly has potential to break things.

          Show
          price Paul Price added a comment - Changes are fine. Please be sure to run CI before merging, as this certainly has potential to break things.
          Hide
          rowen Russell Owen added a comment -

          I did run CI (before putting the ticket up for review), expecting the integration test break. When it did not I investigated a bit further. It turns out that SdssCalibrateTask already used AstrometryTask, so the integration test is not sensitive to this change.

          I also checked obs_* packages for needed changes to config override files. What I found:

          obs_subaru needed minor tweaks:

          • processStack.py had one override that I deleted because it was not valid with AstrometryTask and no equivalent is necessary
          • processCcd.py retargeted the astrometry task to AstrometryTask; I removed the retarget since it is no longer necessary

          obs_cfht had one override that left alone:

          • processCcd.py config file supports either task using a try/except, where the try clause works with AstrometryTask and the except with ANetAstrometryTask. I left that in case users want to be able to switch astrometry tasks.

          I did not find any relevant overrides in any other obs_* packages

          Show
          rowen Russell Owen added a comment - I did run CI (before putting the ticket up for review), expecting the integration test break. When it did not I investigated a bit further. It turns out that SdssCalibrateTask already used AstrometryTask, so the integration test is not sensitive to this change. I also checked obs_* packages for needed changes to config override files. What I found: obs_subaru needed minor tweaks: processStack.py had one override that I deleted because it was not valid with AstrometryTask and no equivalent is necessary processCcd.py retargeted the astrometry task to AstrometryTask; I removed the retarget since it is no longer necessary obs_cfht had one override that left alone: processCcd.py config file supports either task using a try/except, where the try clause works with AstrometryTask and the except with ANetAstrometryTask. I left that in case users want to be able to switch astrometry tasks. I did not find any relevant overrides in any other obs_* packages

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Paul Price
            Watchers:
            Dominique Boutigny, Paul Price, Russell Owen, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.